-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for zstd compressed kernel and modules #1668
Merged
arnaldo2792
merged 4 commits into
bottlerocket-os:develop
from
arnaldo2792:zstd-support
Jul 30, 2021
Merged
Support for zstd compressed kernel and modules #1668
arnaldo2792
merged 4 commits into
bottlerocket-os:develop
from
arnaldo2792:zstd-support
Jul 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Jul 27, 2021
arnaldo2792
force-pushed
the
zstd-support
branch
from
July 28, 2021 21:20
4703284
to
bcf9d62
Compare
Force push includes:
|
bcressey
approved these changes
Jul 30, 2021
packages/libzstd/libzstd.spec
Outdated
Comment on lines
17
to
19
%description devel | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
Suggested change
%description devel | |
%description devel | |
%{summary}. |
This commit adds the Zstandard runtime libraries and development headers
This commit adds support for compressed kernel modules using the Zstandard compression algorithm.
This commit adds support to compress both kernel images and modules with the Zstandard compression algorithm.
This commit adds support to compress both kernel images and modules with the Zstandard compression algorithm.
arnaldo2792
force-pushed
the
zstd-support
branch
from
July 30, 2021 17:09
bcf9d62
to
9b7db11
Compare
Forced pushed includes updated description for the |
webern
approved these changes
Jul 30, 2021
@@ -14,3 +14,4 @@ sha512 = "557cdcaec75e5a1ceea2d10862c944e9a65ef54f6ee9da6dc98ce4582418fdc9958aab | |||
|
|||
[build-dependencies] | |||
glibc = { path = "../glibc" } | |||
libzstd = { path = "../libzstd" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closed
This was referenced Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1614
Description of changes:
With these changes, kernel x86_64 images and modules for both arches are compressed using the Zstandard compression algorithm.
Testing done:
aws-dev, aws-k8s-1.19, aws-k8s-1.20, aws-ecs-1 (x86_64, aarch64):
systemctl status
OKjournalctl -p3
OKmodinfo fuse
shows module's name with extension.ko.zst
ebpf.enabled
, this will force compiling and loading the falco driver at runtime.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.