integrate macros into the SDK #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package architecture can be set correctly at build time, so it's not necessary to include it in the name. Signed-off-by: Ben Cressey <[email protected]>
This allows us to add a different bootloader - like shim - that also needs to know the EFI architecture name, without having to update the macros again. Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
webern
approved these changes
Jun 20, 2023
markusboehme
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#108
Description of changes:
Add macros to the SDK under
/etc/rpm/macros.bottlerocket.Changing the SDK in the main repo will trigger a full rebuild of all packages, making it a good time to also drop the target architecture from the package name.
Reworking the GRUB macros will eliminate the need to change them in bottlerocket-os/bottlerocket#3097, which will make
shimthe first stage bootloader.Testing done:
Built variants in the main repo with the changes in bottlerocket-os/bottlerocket#3213.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.