Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add software to the sdk to support twoliter #108

Closed
6 tasks done
Tracked by #13 ...
webern opened this issue Jun 5, 2023 · 5 comments
Closed
6 tasks done
Tracked by #13 ...

add software to the sdk to support twoliter #108

webern opened this issue Jun 5, 2023 · 5 comments
Assignees
Labels
out-of-tree-builds Items needed for twoliter, the out-of-tree build tool

Comments

@webern
Copy link
Contributor

webern commented Jun 5, 2023

Description

Add the following things to the bottlerocket-sdk:

  • cargo make
  • cargo deny
  • docker (the CLI only, not the daemon)
  • Bottlerocket's RPM macros
  • Bootconfig data files

Definition of Done

When the above items have been added to the SDK.

Depends on:

id: texec_sdk
epic: twoliter_exec

Related to bottlerocket-os/bottlerocket#2669

@webern webern added the out-of-tree-builds Items needed for twoliter, the out-of-tree build tool label Jun 5, 2023
@webern
Copy link
Contributor Author

webern commented Jun 8, 2023

It's unusual for us to require something to be released before the GitHub issue is done. So I changed the definition of done and added bottlerocket-os/bottlerocket#3187

@bcressey
Copy link
Contributor

bcressey commented Jun 8, 2023

We already have cargo-deny in the SDK, so I crossed that off.

@bcressey
Copy link
Contributor

bcressey commented Jun 8, 2023

For the bootconfig data, we have two files:

I'm not sure what the fate of the other content in tools will be long-term; maybe it all gets relocated to a "contrib" repo of some sort, or rewritten as twoliter helper commands (e.g. twoliter-start-local-vm can be a local helper script invoked by twoliter start-local-vm ...), which can embed the data file as a base64 string or whatever.

@webern
Copy link
Contributor Author

webern commented Jun 9, 2023

I'm not sure what the fate of the other content in tools

Most of the rest of the tools will go to the twoliter GitHub repository and be "embedded" in with the twoliter CLI. But you're right, I haven't thought about the "workflow" and "helper" type scripts. It's possible those conveniences could also be added to twoliter.

@bcressey
Copy link
Contributor

Added these to the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
out-of-tree-builds Items needed for twoliter, the out-of-tree build tool
Projects
None yet
Development

No branches or pull requests

2 participants