Kit changes for Bootstrap Commands #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyush-jena
force-pushed
the
develop
branch
2 times, most recently
from
cecd88e
to
b8b8dcd
Compare
piyush-jena
force-pushed
the
develop
branch
3 times, most recently
from
32249c5
to
1af1cae
Compare
arnaldo2792
requested changes
Aug 12, 2024
piyush-jena
force-pushed
the
develop
branch
3 times, most recently
from
c50bda9
to
d0fcf03
Compare
piyush-jena
force-pushed
the
develop
branch
11 times, most recently
from
737bde6
to
a4a72e2
Compare
cbgbt
reviewed
Aug 20, 2024
I figured out the encoding bit. Apparently handlebars HTML-encodes data by default with the "double-stache". If you "triple-stache", it embeds it directly. |
piyush-jena
force-pushed
the
develop
branch
2 times, most recently
from
905f136
to
6fc04f4
Compare
cbgbt
reviewed
Aug 24, 2024
piyush-jena
force-pushed
the
develop
branch
9 times, most recently
from
8d28192
to
32b7b73
Compare
bcressey
reviewed
Sep 3, 2024
piyush-jena
force-pushed
the
develop
branch
2 times, most recently
from
bd88c26
to
1cf0639
Compare
|
Forced push addresses the following:
|
piyush-jena
force-pushed
the
develop
branch
2 times, most recently
from
3a3bed4
to
f438f12
Compare
|
Forced push addresses the following:
|
bcressey
approved these changes
Sep 4, 2024
cbgbt
approved these changes
Sep 4, 2024
Comment on lines
+64
to
+67
| fn iter(self) -> impl Iterator<Item = (Identifier, BootstrapCommand)> { | ||
| self.bootstrap_commands.into_iter() | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this is fine, but as a Rust tip, there's the IntoIter in std that you can implement for this behavior, which can make calling other APIs that expect IntoIter ergonomic.
|
forced push removes the hack commit to use the official settings-sdk |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
This PR contains core-kit changes to add
bootstrap-commands. The relevant settings-sdk changes are in PR 46Testing done:
Test case 1: 2 bootstrap commands
first boot sets
motdtohelloworld3second boot sets
motdtohelloworld1Test case 2: No bootstrap commands
No boot issues.
Note:
3 files have been modified to build successfully. "sources/api/Cargo.toml", "sources/deny.toml", "sources/Cargo.lock". These are dependent on the settings-sdk changes in PR 46. They will be reverted back at the end of code review.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.