Conversation
Codecov Report
@@ Coverage Diff @@
## v2 #2417 +/- ##
==========================================
+ Coverage 97.62% 97.64% +0.01%
==========================================
Files 56 57 +1
Lines 10685 10808 +123
==========================================
+ Hits 10431 10553 +122
- Misses 254 255 +1
Continue to review full report at Codecov.
|
stealthycoin
approved these changes
Jun 16, 2021
nateprewitt
approved these changes
Jun 16, 2021
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Looks like a clean port. Thanks!
This commit pulls in CRT auth abstractions from the develop branch in order to have a starting to point to pull in future updates related to CRT auth. Note the code does not actually use any of the CRT auth abstractions when making API requests. The main difference in porting the package is that because CRT is a required dependency there is no branching logic for conditionally using CRT auth. Eventually, we should remove the pure-Python sigv4 auth abstractions and completely rely on the CRT auth abstractions for sigv4 signing.
nateprewitt
reviewed
Aug 3, 2021
nateprewitt
approved these changes
Aug 3, 2021
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Still looks good, thanks for rebasing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in CRT auth abstractions from the develop branch in order to have a starting to point to pull in future updates related to CRT auth. Note the code does not actually use any of the CRT auth abstractions when making API requests. The main difference in porting the package is that because CRT is a required dependency there is no branching logic for conditionally using CRT auth. Eventually, we should remove the pure-Python sigv4 auth abstractions and completely rely on the CRT auth abstractions for sigv4 signing.
For reference the changes should follow closely to the original PR that added CRT auth to the develop branch: #2350