CRT Signer Integration#2350
Merged
nateprewitt merged 5 commits intoboto:developfrom Apr 14, 2021
Merged
Conversation
joguSD
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we've fixed the
seekinterface issues (boto/s3transfer#102) ins3transferwe should be able to merge this. This PR is an identical copy of #2330.Note: The CRT integration in botocore is currently a beta feature that will be seeing iteration in the near future. You can enable these features for testing with by pip installing
botocore[crt]. This will add an additional dependency (awscrt) to your environment, enabling these new features. This should not be considered "stable" for production at this time.This PR will be the first integration of CRT functionality into Botocore. A new optional module for CRT-based signers is being added to
auth.py, allowing us to utilize a more uniform set of functionality in the AWS SDKs. The end goal will be to provide more performant, streamlined, and consistent SDKs across AWS.