Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default parameters in constructor of IncrementalFixedLagSmoother.h #151

Closed
wants to merge 1 commit into from
Closed

fix default parameters in constructor of IncrementalFixedLagSmoother.h #151

wants to merge 1 commit into from

Conversation

duyanwei
Copy link

@duyanwei duyanwei commented Oct 17, 2019

Fixes #150


This change is Reviewable

@duyanwei duyanwei closed this Oct 17, 2019
@duyanwei duyanwei reopened this Oct 17, 2019
@duyanwei duyanwei closed this Oct 17, 2019
@duyanwei duyanwei deleted the yw/fix_isam2_params branch October 17, 2019 14:02
@duyanwei duyanwei restored the yw/fix_isam2_params branch October 17, 2019 14:03
@@ -114,6 +114,14 @@ class GTSAM_UNSTABLE_EXPORT IncrementalFixedLagSmoother: public FixedLagSmoother
const ISAM2Result& getISAM2Result() const{ return isamResult_; }

protected:

/* Create default parameters */
ISAM2Params getDefaultParams() const {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be static, and renamed to `DefaultISAM2Params'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dellaert
Copy link
Member

Added a comment, but PR seems to be closed?

@duyanwei
Copy link
Author

duyanwei commented Oct 17, 2019

Added a comment, but PR seems to be closed?

I may have created two same PRs, please checkout #152 @dellaert

varunagrawal added a commit that referenced this pull request Oct 28, 2022
b37a1fec6 Merge pull request #154 from borglab/matlab/properties
93dec957a convert class properties to type parser.Variable so that the property collector functions are written correctly
d84e07f56 fix bug with proper closing of global functions
5a8505235 define setter and getter collector functions for cpp file
5067655e2 abstract out unwrap_argument and collector_return to their own functions
1ce29d71d add properties to properties block of .m file and add setters and getters
0c3e5573d write properties in class comment
9d85f7b6a disable superfluous pylint warnings
b45994d34 Merge pull request #152 from borglab/pybind-2.10
76ba199a2 upgrade pybind to 2.10
16e4e674b Merge pull request #150 from borglab/feature/parent_class_template
c7d1a466f Merge pull request #151 from borglab/fix/function_template_parameter_namespace
7278a309d retain namespace for template arguments
18ae5fb04 implement parent class allowed to have template parameters
fd4437899 unit tests for parent classes allowed to have template parameters

git-subtree-dir: wrap
git-subtree-split: b37a1fec689d6a42837a3bfb4dc947674e72be54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findUnusedFactorSlots should be true
2 participants