Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid Elimination with Normalization Constant #1360

Merged
merged 83 commits into from
Jan 4, 2023
Merged

Hybrid Elimination with Normalization Constant #1360

merged 83 commits into from
Jan 4, 2023

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Dec 31, 2022 •
edited
Loading

  • FactorAndConstant::error
  • Improve docstrings.
  • Add log of normalization constant.

@varunagrawal varunagrawal self-assigned this Dec 31, 2022
@dellaert
Copy link
Member

I have a few changes as well, not pushed yet, so we should chat… mostly in python.

@varunagrawal
Copy link
Collaborator Author

Sure thing. Mine's all in C++. I was pretty productive at Schiphol.

I'll be landing in ATL at 8 pm so might be too late until I get home. Tomorrow afternoon/evening maybe?

dellaert and others added 21 commits December 31, 2022 14:43
@varunagrawal
serialize inner_, need to test
46acba5
@varunagrawal
comment out failing tests, need to serialize DecisionTree
41c73fd
@varunagrawal
kill unnecessary method
e01f7e7
@varunagrawal
make header functions as inline
9e7fcc8
@varunagrawal
simplify HybridConditional equality check
3771d63
@varunagrawal
Merge pull request #1363 from borglab/hybrid/test_with_evaluate-2
385ae34
@varunagrawal
DecisionTree serialization
99a3fba
@varunagrawal
serialization support for DecisionTreeFactor
2653c2f
@varunagrawal
fix equality of HybridDiscreteFactor and HybridGaussianFactor
0ab15cc
@varunagrawal
hybrid serialization tests
3f2bff8
@varunagrawal
GaussianMixture serialization
74142e4
@varunagrawal
fix minor bug in HybridConditional and test its serialization
2bb4fd6
@varunagrawal
serialize DiscreteConditional
6fcc087
@varunagrawal
serialization tests for HybridBayesNet and HybridBayesTree
230f65d
@varunagrawal
move discrete serialization tests to common file to remove export key…
4cb910c 
… collision
@varunagrawal
Merge pull request #1362 from borglab/hybrid/test_with_evaluate
5cdff9e
@varunagrawal varunagrawal marked this pull request as ready for review January 4, 2023 06:53
@varunagrawal
Copy link
Collaborator Author

@dellaert please let me know when I can merge this in. :)

dellaert
dellaert approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@varunagrawal varunagrawal merged commit 1c411eb into develop Jan 4, 2023
@varunagrawal varunagrawal deleted the hybrid/elimination branch January 4, 2023 18:29
@dellaert dellaert added this to the Hybrid Inference milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
Hybrid Inference
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert