Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HybridValues specify continuous then discrete #1355

Merged
merged 2 commits into from
Dec 30, 2022
Merged

HybridValues specify continuous then discrete #1355

merged 2 commits into from
Dec 30, 2022

Conversation

varunagrawal
Copy link
Collaborator

Updated HybridValues to take continuous values first, and then discrete so that we are consistent.

@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label Dec 29, 2022
@varunagrawal varunagrawal self-assigned this Dec 29, 2022
xsj01
xsj01 approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@xsj01 xsj01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal
Copy link
Collaborator Author

@dellaert FYI

@varunagrawal varunagrawal merged commit 04ba193 into develop Dec 30, 2022
@varunagrawal varunagrawal deleted the hybridvalues-order branch December 30, 2022 03:09
@dellaert dellaert added this to the Hybrid Inference milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsj01 xsj01 xsj01 approved these changes

@dellaert dellaert Awaiting requested review from dellaert

Assignees

@varunagrawal varunagrawal

Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
Hybrid Inference
Development

Successfully merging this pull request may close these issues.
3 participants
@varunagrawal @xsj01 @dellaert