Hybrid Bayes Net/Tree Optimize #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Optimal discrete assignment needs to be solved by using MPE, CC @xsj01 |
ProfFan
reviewed
Aug 28, 2022
| auto reversed = boost::adaptors::reverse(gbn); | ||
| gbn = GaussianBayesNet(reversed.begin(), reversed.end()); | ||
| #endif | ||
|
|
||
| // Return the optimized bayes net. | ||
| return gbn.optimize(); |
There was a problem hiding this comment.
Does this mean that gbn.optimize does not work when the bayes net has non sequential order?
There was a problem hiding this comment.
The GBN needs to be topologically sorted so that it optimizes parents before children, and for some reason, the GBN is reverse topologically sorted only when TBB is enabled.
ProfFan
reviewed
Aug 29, 2022
| gbn.push_back(gm(assignment)); | ||
|
|
||
| } catch (std::exception &exc) { | ||
| // if factor at `idx` is discrete-only, just continue. |
There was a problem hiding this comment.
assert that idx is indeed discrete only
There was a problem hiding this comment.
Made the assertion in #1282
ProfFan
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
optimizemethods for the Hybrid Bayes Net and the Hybrid Bayes Tree.The idea is that if we know the optimal discrete assignment, we can pick out the Gaussian Bayes Net and just optimize that.