Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exports on Windows #1257

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Conversation

Tobias-Fischer
Copy link
Contributor

Hi there,

This is the first of a few PRs which emerged from our efforts to package gtsam in conda-forge (see https://github.com/conda-forge/gtsam-feedstock/tree/main/recipe).

Related: #1109

This one is relatively simple - there is no associated cpp file that exports symbols, so GTSAM_EXPORT needs to be removed in these two instances.

Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks @Tobias-Fischer

@varunagrawal varunagrawal merged commit 1d554d8 into borglab:develop Aug 1, 2022
@Tobias-Fischer Tobias-Fischer deleted the fix-exports branch August 1, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants