correctly parse optimizer params for base optimizer in gnc

[yunzc]

Parse the parameters for the base optimizer in GNC.

[varunagrawal]

Awesome! I ran the CI and will merge once it passes. @yunzc you should probably also add a unit test to expose this "bug" so that it is caught in the future.

[yunzc]

Sounds good @varunagrawal. I can't seem to find unit tests for Gnc in general, so it might be good to add that. I can add that to my TODO list.

[varunagrawal]

@yunzc can we expect that soon? A lack of unit tests really hurts confidence in our code.

[dellaert]

So do we merge this or wait for a unit test? @varunagrawal don't merge without asking anyone :-/

[lucacarlone]

I'll take a stab at adding a unit test over the weekend! ok @dellaert , @varunagrawal and @yunzc ?

[yunzc]

@lucacarlone sounds good! Thanks!

[lucacarlone]

@yunzc - pleasure!

[varunagrawal]

Yes, that's why I haven't merged it yet :)

[lucacarlone]

@varunagrawal @yunzc : done! this is ready to go after the CI finishes.

[varunagrawal]

We should be good to merge this now

[dellaert]

Done!

[lucacarlone]

yay!