Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html renderers in discrete #1022

Merged
merged 10 commits into from
Jan 10, 2022
Merged

html renderers in discrete #1022

merged 10 commits into from
Jan 10, 2022

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Jan 9, 2022 •
edited
Loading

This PR adds html renderers for all discrete types for which markdown existed, and additionally for DiscreteValues. Importantly, it also

  • moves Names to DiscreteKeys
  • makes the free version cartesianProduct a static method of Assignment
  • adds a specialization of that in DiscreteValues
  • markdown in DiscreteConditional is significantly re-factored to avoid copy/paste

@dellaert dellaert added the high-priority Need this done quickly label Jan 9, 2022
@dellaert dellaert requested a review from ProfFan January 9, 2022 20:10
@dellaert dellaert changed the title Initial attempt at html html renderers in discrete Jan 9, 2022
ProfFan
ProfFan approved these changes Jan 9, 2022
View reviewed changes
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some comments to unblock

gtsam/discrete/tests/testDiscreteValues.cpp Show resolved Hide resolved
gtsam/discrete/DiscreteBayesTree.cpp Show resolved Hide resolved
gtsam/discrete/DiscreteValues.cpp Outdated Show resolved Hide resolved
gtsam/discrete/DiscreteValues.cpp Outdated Show resolved Hide resolved
@dellaert dellaert merged commit e17cfb1 into develop Jan 10, 2022
@dellaert dellaert deleted the feature/html_renderers branch January 10, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

Assignees
No one assigned
Labels
high-priority Need this done quickly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @ProfFan