Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup copy/pasta and use new codemirror-blocks toolkit API #23

Merged
merged 16 commits into from
Jul 30, 2021

Conversation

pcardune
Copy link
Collaborator

@pcardune pcardune commented Jul 9, 2021

The only thing more satisfying than writing a bunch of code is deleting a bunch of code. This PR deletes a bunch of files that were never being used, and a bunch of other files that no longer need to be used with the new toolkit API.

TODO before this can be merged:

  • Wait for the toolkit branch in codemirror-blocks to be merged: Implement toolkit API codemirror-blocks#374
  • Figure out what the story is with css bundling. Currently it's bundled with the minified js bundle but sounds like it shouldn't be?
  • Figure out what the story is with the "*-test-old.js" files in spec/ui as they are currently not being run.

@pcardune
Copy link
Collaborator Author

pcardune commented Jul 9, 2021

@schanzer couple questions for you:

  1. what's the story with the "spec/ui/*-test-old.js" files? Do they need to run? Do they need to pass?
  2. do we want to generate a blocks.css file during the build process? The code to do it has been commented out but it looks like wescheme.org is still loading one?

@pcardune pcardune marked this pull request as ready for review July 29, 2021 00:28
@pcardune pcardune merged commit 696eb9d into master Jul 30, 2021
@pcardune pcardune deleted the pcardune-toolkit branch July 30, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants