-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement toolkit API #374
Conversation
…d type declarations
…ey get overwritten/extended by plugins
@schanzer I believe this is ready to merge. There are more changes to be made in pyret-blocks and wescheme-blocks, but my pull requests in those repos address the main compatibility issues that would prevent this PR from being merged. |
@pcardune this is huge. Thank you!! Before I merge, I want to confirm that you're intentionally leaving one of the TODO items unchecked? I'm also curious about why the |
Yes, I'm intentionally leaving one of the TODO items unchecked. The I'll go ahead and merge this PR and the corresponding PRs for wescheme-blocks and pyret-blocks. Since the pyret-blocks and wescheme-blocks repos have always pointed to the latest commit in the codemirror-blocks master branch instead of a specific commit hash, all old commits to wescheme-blocks and pyret-blocks will probably be broken because they will be pointing to a version of codemirror-blocks that is no longer compatible. Likewise, any outstanding branches in wescheme-blocks and pyret-blocks will probably also break until they merge master. |
This PR attempts to refactor and consolidate all the code and configuration that was copy/pasted across codemirror-blocks, wescheme-blocks, and pyret-blocks into a small "toolkit" library that lives in "src/toolkit". Here is a summary of the changes:
npm run build
will generate a lib/ directory containing transpiled commonjs versions of all the files in src/, allowing dependents to import individual files from codemirror-blocks withrequire("codemirror-blocks/lib/<filename>");
require("codemirror-blocks/lib/toolkit/<module>")
TODO BEFORE MERGE: