build-sys: Enable rhsm feature on rhel-like systems by default #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the rhsm cargo feature by default on RHEL-like systems by inspecting /usr/lib/os-release in the Makefile. This is a good step towards unifying the build configurations. My review focuses on improving the portability and clarity of the Makefile changes. I've identified a portability issue with the shell command used for OS detection and suggested a more robust, POSIX-compliant alternative. Additionally, I've proposed a change to make the build command cleaner by conditionally including the --features flag.
cgwalters
force-pushed
the
rhsm-default
branch
from
df840f1 to
86631a8
Compare
The Dockerfile right now doesn't build an RPM, so this ensures the two build systems match. We should probably also change the RPM to use this Makefile. Motivated by accidentally merging a change that breaks with the feature on. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
rhsm-default
branch
from
86631a8 to
722ab14
Compare
jeckersb
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile right now doesn't build an RPM, so this ensures the two build systems match. We should probably also change the RPM to use this Makefile.
Motivated by accidentally merging a change that breaks with the feature on.