rhsm: Update function call to match new Storage API #1530
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the publish_facts function to align with a new Storage API. The changes are functionally correct, but I've identified an opportunity to simplify the implementation by removing a redundant function call. This will make the code more efficient and easier to read. My suggestion is to directly use the complete return value from get_status_require_booted instead of calling get_status a second time.
crates/lib/src/rhsm.rs
Outdated
| let (booted_deployment, ..) = crate::status::get_status_require_booted(ostree)?; | ||
| let (_deployments, host) = crate::status::get_status(ostree, Some(&booted_deployment))?; |
There was a problem hiding this comment.
The get_status_require_booted function already computes and returns the host object. The subsequent call to get_status is redundant and can be removed for better performance and code clarity. You can directly destructure the tuple returned by get_status_require_booted to get the host.
| let (booted_deployment, ..) = crate::status::get_status_require_booted(ostree)?; | |
| let (_deployments, host) = crate::status::get_status(ostree, Some(&booted_deployment))?; | |
| let (_, _, host) = crate::status::get_status_require_booted(ostree)?; |
|
Ah right the main CI doesn't enable the rhsm feature since we only turn it on via the spec file, and the packit builds aren't gating. |
Update according to API changes introduced in bootc-dev#1525 Signed-off-by: Johan-Liebert1 <[email protected]>
Johan-Liebert1
force-pushed
the
rhsm-fix
branch
from
2b3cd3c to
f5d2621
Compare
➡️ #1531 should help that from one angle, but I guess we may also need to make packit gating |
2 participants
No description provided.