Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version numbers to reflect VC++ 2017 RTW, aka RTM #125

Closed
wants to merge 1 commit into from

Conversation

Beman
Copy link
Contributor

@Beman Beman commented Mar 11, 2017

VC++ 2017 shipped March 7th. This P/R reflects the actual RTW version numbers. Note: Release to Manufacturing (RTM) is now called Release to Web (RTW).

Also note that Microsoft has also changed to incrementing _MSC_VER monotonically for each release.

Please review carefully. I tested only with the Visual Studio IDE since Boost.Build does not work yet for VC++2017.

--Beman

Copy link
Contributor

@jhunold jhunold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See boostorg/build#157 and boostorg/build#167 for the relevant discussion which led to use 14.10 instead of 15.0

# define BOOST_COMPILER_VERSION 14.0
# elif _MSC_VER < 1911
# define BOOST_COMPILER_VERSION 15.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 14.10 in order to be consistend with the latest Boost.Build patches.
# define BOOST_COMPILER_VERSION 14.10

@KindDragon
Copy link
Contributor

PR #119 should fix this

@jzmaddock
Copy link
Collaborator

This is now addressed in develop.

@jzmaddock jzmaddock closed this Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants