Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toolset name for VS2017 #119

Closed
wants to merge 1 commit into from
Closed

Conversation

KindDragon
Copy link
Contributor

I think we should change VS2017 toolset name to vc141 before next Boost release.

Related to boostorg/build#167

/cc @AndrewPardoe

@jzmaddock
Copy link
Collaborator

Some comments/questions:

  1. Boost.Build needs to change this first Config just matches whatever lib names are produced by BB.
  2. Boost.Build needs to support the next visual studio release period before this means much of anything anyway.
  3. Do we have official confirmation of what MS are calling this release? What's the _MSC_VER version?

Thanks.

@KindDragon
Copy link
Contributor Author

KindDragon commented Feb 20, 2017

Boost.Build needs to change this first Config just matches whatever lib names are produced by BB.

PR boostorg/build#167 should fix this

Boost.Build needs to support the next visual studio release period before this means much of anything anyway.

Now BB supports VS2017 if VS is installed to default path or you run Boost Build from "Developer Command Prompt for VS 2017".

Do we have official confirmation of what MS are calling this release? What's the _MSC_VER version?

It should be VS2017 and _MSC_VER=1910. I think @AndrewPardoe can help us verify this.

@AndrewPardoe
Copy link

VS2017 contains the VC 14.1 toolset, or vc141. Part of the confusion is that the compiler's internal version, 19.10, is five higher than the public version, 14.1. So _MSC_VER=1910, but the toolset is vc141.

@jzmaddock
Copy link
Collaborator

This is now addressed in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants