Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the has sortorder for taxonomies 3001 (#3016) #3017

Merged

Conversation

I-Valchev
Copy link
Member

See #3002 #3016

* has_sortorder functionality as 3.7. Closes #3001

* Update _taxonomies.html.twig

* setcontent tests

* [bug] prefix and postfix ids

* fix(doctrine): cast support

* fix(data casting): number field stored as ["xxx"] in value column

* fix(tests): maintenance menu has 7 items

* ROLE_WEBSERVICE can be an assignable rol (to use a user to query the API)

* fix(tests): Add admin user to ROLE_WEBSERVICE to use the API

Co-authored-by: Pablo Sanchez <[email protected]>
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green light! This is also Good-to-go, right? 🟢

@bobdenotter
Copy link
Member

Thank you @psanchezg! 👍

@bobdenotter bobdenotter merged commit 5d96acf into master Dec 14, 2021
@bobdenotter bobdenotter deleted the psanchezg-port-the-has_sortorder-for-taxonomies-3001 branch December 14, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants