Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't break with TaxonomyRepository::factory() must be of the type string, int given #2203

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

I-Valchev
Copy link
Member

@I-Valchev I-Valchev commented Dec 1, 2020

Fixes #2201

PHP Arrays are THE WORST

A key may be either an integer or a string. If a key is the standard representation of an integer, it will be interpreted as such (i.e. "8" will be interpreted as 8, while "08" will be interpreted as "08"). 🤦‍♂️

@bobdenotter
Copy link
Member

Haha, Arrays are terrible indeed! :-D

@bobdenotter
Copy link
Member

Merged into both the 4.1 and master branches.

@bobdenotter bobdenotter merged commit 3ae68a8 into master Dec 4, 2020
@bobdenotter bobdenotter deleted the bugfix/integer-taxonomy-slug branch December 4, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taxonomy with Number and + converted to int and cannot be added to a content type
2 participants