Taxonomy with Number and + converted to int and cannot be added to a content type

[develth]

I have a taxonmy option called '66+', when adding it at the Backend to the Content-Type, i get an Error:

Argument 2 passed to Bolt\Repository\TaxonomyRepository::factory() must be of the type string, int given, called in /var/www/bolt/vendor/bolt/core/src/Controller/Backend/ContentEditController.php on line 482

When debugging in Frontend, i recognized that the value is already set as int by vue.

value='["50-65",66]'

Details

Question	Answer
Relevant Bolt Version	4.1.8
Install type	Composer install
BC Break	no
PHP version	7.4
Web server	Nginx
For UX/UI issues	Firefox Developer Edition 84.0b4

Reproduction

Add Taxonmy like

offerAges:
  name: Age-Groups
  singular_name: Age-Group
  slug: ages
  singular_slug: age
  behaves_like: categories
  multiple: true
  options: [ "8-10", "10-14", "14-16", "16-18", "18-20", "20-29", "30-49", "50-65", "66+" ]
  required: true

Steps to reproduce

Add Taxonmy to Content-Type

Expected result

Should save '66+', not 66.

Actual result

Error, because converted to integer

[bobdenotter]

Moving to the correct repository -> bolt/core

Nevermind! It's already in the correct one.. We'll take a look!

[develth]

Also happens with a

"66-∞"

[develth]

When change to object with string definition it works:
options: { 8to10: "8-10", 10to14: "10-14", 14to16: "14-16", 16to18: "16-18", 18to20: "18-20", 20to29: "20-29", 30to40: "30-49", 50to65: "50-65", age66AndOlder: "66+" }

[I-Valchev]

@develth I've had a look and, in fact, there's a reason why we do it this way.

core/src/Configuration/Parser/TaxonomyParser.php

Line 84 in 1aa117d

$optionKey = Str::slug($optionKey);

This line makes sure that, unless a key is set, the key is slugified. In the example you provide, 66+ becomes 66 because of how cucur/slugify works. Removing that line, while not breaking straightaway, does not show saved taxonomies with keys that are not slugs. The main reason taxonomies are slugs is that it is the right approach to be able to fetch them from the config, e.g.

https://github.com/bolt/core/blob/master/templates/content/_taxonomies.html.twig

The "fix" for this is to make sure that the key is always the string "66" rather than the int 66. In both cases it is without the +, because it's sugified.

[develth]

Thanks for the clarification about that behaviour.
Make sure that there is a string instead of a int would be the best 'fix'

[I-Valchev]

@develth no worries, thanks for bringing this up! It's a pretty interesting "edge case" 😅

[I-Valchev]

Let's close this one.