Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paired_replacements() converts a single ' * ' to '<em>/em>' #46

Closed
bobbingwide opened this issue Feb 4, 2017 · 1 comment
Closed

paired_replacements() converts a single ' * ' to '<em>/em>' #46

bobbingwide opened this issue Feb 4, 2017 · 1 comment
Assignees
Labels

Comments

@bobbingwide
Copy link
Owner

In http://www.oik-plugins.com/oik_api/_bw_show_contact_form_oik/ the Description contains
Note: The * indicates Required field

Expected output

As shown. The single * should not be converted.

Actual output

Note: The <em>/em> indicates Required field

This leads to the rest of the content being italicised.

Explanation

The asterisk is incorrectly treated as markdown emphasis by the paired_replacements() function.

Proposed solution

Check for overlaps in the paired replacements.

Workaround

Change the Description

@bobbingwide bobbingwide self-assigned this Feb 4, 2017
@bobbingwide bobbingwide added the bug label Feb 4, 2017
@bobbingwide
Copy link
Owner Author

bobbingwide commented Feb 4, 2017

Questions:

  • Should ** be treated as emphasis markdown? A. No.
  • do we need at least one, non-blank character between the asterisks ? ? A. Yes.
  • What about ***? A. Not tested in the published solution. Git doesn't convert it but we might.

bobbingwide added a commit that referenced this issue Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant