Skip to content

fix: v2.2 prefetcher warmup#359

Merged
chee-chyuan merged 6 commits into
develop-v2.2-newfrom
fix/v2.2-prefetcher-warmup
May 26, 2026
Merged

fix: v2.2 prefetcher warmup#359
chee-chyuan merged 6 commits into
develop-v2.2-newfrom
fix/v2.2-prefetcher-warmup

Conversation

@constwz
Copy link
Copy Markdown
Contributor

@constwz constwz commented May 26, 2026

Description

add a description of your changes here...

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Potential Impacts

  • add potential impacts for other components here
  • ...

MqllR and others added 6 commits May 25, 2026 15:42
BscBlock::rlp_length was filtering out empty withdrawals (Some([]))
by treating them as None, making the computed block size 1 byte
smaller than geth/erigon for any block that carries an empty
withdrawals list.

(cherry picked from commit 12556dc)
* chore: add more for debug p2p

* chore: add more logs

* chore: avoid fetch newest block by newblock which result in failed fetch and p2p reset

* chore: avoid fetch unnecessary newest block

* chore: request_blocks_by_range only by v2 peer

* chore: fetch block prefer announce peer

* chore: make reth-bsc peer-manager similar to geth-bsc

* chore: try some p2p config

* chore: update peer config

* fix: fix forward vote bug which too large msg

* chore: restore reth deps

* chore: remove temp peer dump

* chore: remove useless codes

* chore: add force prune vote when stage sync

* chore: update some trivals

(cherry picked from commit a133c6c)
(cherry picked from commit 7cdb875)
Co-authored-by: joey <10592664+joey0612@users.noreply.github.com>
Co-authored-by: cbh876 <3930922419@qq.com>
Co-authored-by: cbh876 <30834644+constbh@users.noreply.github.com>
(cherry picked from commit a1c132d)
* fix: make receive block metrics correct

* ci: pin udeps job to nightly-2026-05-11

cargo-udeps 0.1.61 segfaults on nightly >= 2026-05-19 due to an
incompatibility with rustc internals. Pin to the last known-good
nightly to unblock CI. A follow-up should migrate to cargo-machete
to remove the nightly fragility entirely.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
(cherry picked from commit 32a07ee)
@constwz constwz requested a review from joey0612 as a code owner May 26, 2026 02:27
@hashdit-bot
Copy link
Copy Markdown

hashdit-bot Bot commented May 26, 2026

Pull Request Review

This PR introduces a broad set of networking, fork-recovery, and mining pipeline improvements for a Rust-based BSC full node, with emphasis on reliability and performance under mainnet conditions. Key updates include version-aware BSC peer registry behavior (bsc/1 vs bsc/2), announcer-aware failover for GetBlocksByRange, safer fork recovery targeting (RecoverTarget), and speculative payload building to warm TrieDB prefetching during out-of-turn backoff. It also refines chain-delay metrics handling for self-mined vs network-received blocks, adds vote-pool pruning safeguards, and aligns RLP length computation for withdrawals with actual encoding behavior.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@chee-chyuan chee-chyuan merged commit 38dc30a into develop-v2.2-new May 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants