Skip to content

fix: bsc protocol stale registry tx#355

Merged
will-2012 merged 9 commits into
developfrom
fix/bsc-protocol-stale-registry-tx
May 19, 2026
Merged

fix: bsc protocol stale registry tx#355
will-2012 merged 9 commits into
developfrom
fix/bsc-protocol-stale-registry-tx

Conversation

@constwz
Copy link
Copy Markdown
Contributor

@constwz constwz commented May 19, 2026

Description

add a description of your changes here...

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Potential Impacts

  • add potential impacts for other components here
  • ...

@constwz constwz requested a review from joey0612 as a code owner May 19, 2026 08:17
@hashdit-bot
Copy link
Copy Markdown

hashdit-bot Bot commented May 19, 2026

Pull Request Review

This PR updates BSC protocol peer registry behavior to handle stale GetBlocksByRange channels more robustly. Specifically, when sending a GetBlocksByRange command fails, it now conditionally evicts the matching stale registry entry (using same_channel to avoid racing with reconnects) and proactively disconnects the peer to force re-handshake and re-registration. The rest of the file context shows existing version-aware peer handling, failover logic, and tests, but the functional diff is focused on stale entry cleanup and reconnect triggering.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@will-2012 will-2012 merged commit a1c132d into develop May 19, 2026
14 of 16 checks passed
chee-chyuan pushed a commit that referenced this pull request May 21, 2026
Co-authored-by: joey <10592664+joey0612@users.noreply.github.com>
Co-authored-by: cbh876 <3930922419@qq.com>
Co-authored-by: cbh876 <30834644+constbh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants