New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new fork block and precompile contract for BEP294 and BEP299 #1874

Merged

unclezoro merged 4 commits into bnb-chain:bc-fusion from pythonberg1997:bc-fusion

Nov 30, 2023

Contributor

pythonberg1997 commented Sep 18, 2023 •

edited by j75689

Loading

Description

This pr is to support

BEP-294: BSC Native Staking after BC Fusion
BEP-299: Token Migration after BC Fusion

Rationale

See 4. Motivation in BEP-294, BEP-299,

Changes

Notable changes:

add new precompile contract verifyDoubleSignEvidence and secp256k1SignatureRecover
add new systemTx to parlia to update validatorSet everyday after the fusion fork
add upgrade setting

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/vm/contracts.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/vm/contracts.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/vm/contracts.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/vm/contracts.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/vm/contracts.go Outdated Show resolved Hide resolved

pythonberg1997 force-pushed the bc-fusion branch from 44092f8 to 45110b8 Compare

October 17, 2023 03:34

pythonberg1997 force-pushed the bc-fusion branch 3 times, most recently from 639fe27 to 12214ef Compare

October 26, 2023 10:41

pythonberg1997 changed the base branch from master to develop

October 26, 2023 10:44

pythonberg1997 force-pushed the bc-fusion branch from 12214ef to 1eea774 Compare

October 26, 2023 16:30

unclezoro reviewed

View reviewed changes

consensus/parlia/abi.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated

+              		sort.SliceStable(validatorHeap, validatorHeap.Less)
+              	} else {
+              		i := 0
+              		for len(validatorHeap) < int(maxElectedValidators.Int64()) && i < len(allValidators) {

Collaborator

unclezoro Oct 31, 2023 •

edited

Loading

This is complicated than I think.

Let's simplify it:
we get allVotingPowers slice, heap.init() it, then pop until 1. top maxElectedValidators, or 2. the heap is empty. Each pop item goes to eligibleValidators

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/fusionfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/vm/contracts_lightclient.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/vm/contracts_lightclient.go Outdated Show resolved Hide resolved

j75689 changed the title ~~feat: add new fork block and precompile contract for BEP294~~ feat: add new fork block and precompile contract for BEP294 and BEP299

j75689 reviewed

View reviewed changes

core/types/block.go Outdated Show resolved Hide resolved

buddh0 reviewed

View reviewed changes

consensus/parlia/parlia.go Outdated Show resolved Hide resolved

buddh0 reviewed

View reviewed changes

miner/worker.go Outdated Show resolved Hide resolved

pythonberg1997 force-pushed the bc-fusion branch from b89b384 to de2215f Compare

November 22, 2023 12:59


          feat: add new fork time and precompile contracts

5365b22

pythonberg1997 force-pushed the bc-fusion branch from de2215f to 5365b22 Compare

November 22, 2023 13:09

j75689 added 2 commits

November 24, 2023 13:12


          fix: rename tmSignatureRecover to secp256k1SignatureRecover (#4)

6a476f5


          fix: rename fusion hard fork to feynman

7e3deb1

NathanBSC reviewed

View reviewed changes

core/systemcontracts/const.go Outdated Show resolved Hide resolved

unclezoro changed the base branch from develop to bc-fusion

November 30, 2023 03:06

unclezoro force-pushed the bc-fusion branch from e853ec1 to 1edb34f Compare

November 30, 2023 03:12

unclezoro reviewed

View reviewed changes

consensus/parlia/feynmanfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

consensus/parlia/feynmanfork.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

core/vm/contracts.go Outdated Show resolved Hide resolved

unclezoro reviewed

View reviewed changes

params/config_test.go Outdated Show resolved Hide resolved


          fix: fix review comments

285422e

pythonberg1997 force-pushed the bc-fusion branch from e3e7a3d to 285422e Compare

November 30, 2023 06:20

unclezoro approved these changes

View reviewed changes

unclezoro merged commit 030e416 into bnb-chain:bc-fusion

5 checks passed

Gabo139 approved these changes

View reviewed changes

octavio12345300 reviewed

View reviewed changes

octavio12345300 left a comment

gracias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

NathanBSC NathanBSC left review comments

octavio12345300 octavio12345300 left review comments

j75689 j75689 left review comments

buddh0 buddh0 left review comments

Gabo139 Gabo139 approved these changes

unclezoro unclezoro approved these changes

Labels

None yet