Skip to content

Commit

Permalink
fix: fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
pythonberg1997 committed Nov 30, 2023
1 parent 7e3deb1 commit 285422e
Show file tree
Hide file tree
Showing 15 changed files with 1,966 additions and 1,774 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ on:
- develop

pull_request:
branches:
- master
- develop


jobs:
unit-test:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/commit-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ on:
- develop

pull_request:
branches:
- master
- develop


jobs:
commitlint:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ on:
- develop

pull_request:
branches:
- master
- develop

jobs:
truffle-test:
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ on:
- develop

pull_request:
branches:
- master
- develop


jobs:
golang-lint:
Expand Down Expand Up @@ -44,7 +42,7 @@ jobs:
${{ runner.os }}-go-
- run: |
go mod download
go mod tidy
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ on:
- develop

pull_request:
branches:
- master
- develop


jobs:
unit-test:
Expand Down Expand Up @@ -50,6 +48,6 @@ jobs:
ANDROID_HOME: "" # Skip android test
run: |
git submodule update --init --depth 1 --recursive
go mod download
go mod tidy
make test
2 changes: 1 addition & 1 deletion accounts/abi/bind/bind_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2127,7 +2127,7 @@ func TestGolangBindings(t *testing.T) {
t.Fatalf("failed to replace binding test dependency to current source tree: %v\n%s", err, out)
}

replacer = exec.Command(gocmd, "mod", "edit", "-x", "-require", "github.com/tendermint/[email protected]", "-replace", "github.com/tendermint/tendermint=github.com/bnb-chain/[email protected].15") // Repo root
replacer = exec.Command(gocmd, "mod", "edit", "-x", "-require", "github.com/tendermint/[email protected]", "-replace", "github.com/tendermint/tendermint=github.com/bnb-chain/[email protected].16") // Repo root
replacer.Dir = pkg
if out, err := replacer.CombinedOutput(); err != nil {
t.Fatalf("failed to replace tendermint dependency to bnb-chain source: %v\n%s", err, out)
Expand Down
Loading

0 comments on commit 285422e

Please sign in to comment.