-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Make Discover and Following feed names translatable on Home screen
#8374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
surfdude29
wants to merge
19
commits into
bluesky-social:main
Choose a base branch
from
surfdude29:translate-discover-and-following-feed-names
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f2f0a56
translate `Discover` and `Following` feed names in feed.ts
surfdude29 f371a10
translate `Discover` feed name in DiscoverFallbackHeader.tsx
surfdude29 84d3ca6
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 9d61198
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 f2a0984
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 bdb9864
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 64d17fa
also make `Feeds ✨` string in HomeHeader.tsx translatable
surfdude29 81b7c93
lint
surfdude29 ca91f49
add comment for translators
surfdude29 0c204aa
correct comment
surfdude29 cf43444
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 28a458f
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 d87f19b
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 ad2c215
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 de646cc
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 9e38589
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 b414773
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 6b2a9bf
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 d157c7b
Merge branch 'bluesky-social:main' into translate-discover-and-follow…
surfdude29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I opened this PR, I asked Claude about this and realised that this code path only runs when the user is logged out, so I think this means that Discover would only show up as translated in the PWI, and not when logged in?
I asked Claude how to fix it but couldn't come up with anything that looked like it would work 🤔