Make Discover and Following feed names translatable on Home screen#8374
Open
surfdude29 wants to merge 19 commits into
Open
Make Discover and Following feed names translatable on Home screen#8374surfdude29 wants to merge 19 commits into
Discover and Following feed names translatable on Home screen#8374surfdude29 wants to merge 19 commits into
Conversation
surfdude29
commented
May 16, 2025
| @@ -428,7 +431,12 @@ export function usePinnedFeedsInfos() { | |||
| ], | |||
| queryFn: async () => { | |||
| if (!hasSession) { | |||
Contributor
Author
There was a problem hiding this comment.
After I opened this PR, I asked Claude about this and realised that this code path only runs when the user is logged out, so I think this means that Discover would only show up as translated in the PWI, and not when logged in?
I asked Claude how to fix it but couldn't come up with anything that looked like it would work 🤔
surfdude29
changed the title
Discover and Following feed names translatableDiscover and Following feed names translatable on Home screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several users have raised the issue that the name of the Following feed isn't translatable (this also applies to Discover):
These are some of the last hardcoded English strings in the UI.
This PR is an updated version of #3493 (credit to @quiple for the original PR 🙏) and goes part of the way towards a solution by making the default Discover and Following feed names translatable on the Home screen.
EDIT: This PR also makes translatable the Feeds ✨ string that is shown in the tab bar in the PWI and when a user has no pinned feeds.
Fixes #2920
Fixes #3477
Closes #3493
Note
Claude wrote part of the code for this PR and although it passes CI I have not tested it.