Skip to content

Add reasons param to listNotifications #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dholms merged 6 commits into from
Dec 11, 2024
Merged

Add reasons param to listNotifications #3222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ddaefd
Add filter param to listNotifications
gaearon Dec 10, 2024
c7644d8
Codegen
gaearon Dec 10, 2024
415a359
Changeset
gaearon Dec 10, 2024
219582b
update schemas
dholms Dec 10, 2024
3239b5f
tweak schema
dholms Dec 10, 2024
78c5a8d
filter -> reasons
dholms Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/stupid-feet-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@atproto/ozone": patch
"@atproto/bsky": patch
"@atproto/api": patch
"@atproto/pds": patch
---

Add optional reasons param to listNotifications
8 changes: 8 additions & 0 deletions lexicons/app/bsky/notification/listNotifications.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@
"parameters": {
"type": "params",
"properties": {
"reasons": {
"description": "Notification reasons to include in response.",
"type": "array",
"items": {
"type": "string",
"description": "A reason that matches the reason property of #notification."
Copy link
Copy Markdown
Collaborator

@dholms dholms Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We originally had a knownValues here, but it was screwing up some types in the route handler and I just didn't think it was a great use of time to debug. This also prevents us from having to duplicate every new reason in 2 locations.

}
},
"limit": {
"type": "integer",
"minimum": 1,
Expand Down
9 changes: 9 additions & 0 deletions packages/api/src/client/lexicons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8944,6 +8944,15 @@ export const schemaDict = {
parameters: {
type: 'params',
properties: {
reasons: {
description: 'Notification reasons to include in response.',
type: 'array',
items: {
type: 'string',
description:
'A reason that matches the reason property of #notification.',
},
},
limit: {
type: 'integer',
minimum: 1,
Expand Down
2 changes: 2 additions & 0 deletions packages/api/src/client/types/app/bsky/notification/listNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import * as AppBskyActorDefs from '../actor/defs'
import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs'

export interface QueryParams {
/** Notification reasons to include in response. */
reasons?: string[]
limit?: number
priority?: boolean
cursor?: string
Expand Down
9 changes: 9 additions & 0 deletions packages/bsky/src/lexicon/lexicons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8944,6 +8944,15 @@ export const schemaDict = {
parameters: {
type: 'params',
properties: {
reasons: {
description: 'Notification reasons to include in response.',
type: 'array',
items: {
type: 'string',
description:
'A reason that matches the reason property of #notification.',
},
},
limit: {
type: 'integer',
minimum: 1,
Expand Down
2 changes: 2 additions & 0 deletions packages/bsky/src/lexicon/types/app/bsky/notification/listNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import * as AppBskyActorDefs from '../actor/defs'
import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs'

export interface QueryParams {
/** Notification reasons to include in response. */
reasons?: string[]
limit: number
priority?: boolean
cursor?: string
Expand Down
9 changes: 9 additions & 0 deletions packages/ozone/src/lexicon/lexicons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8944,6 +8944,15 @@ export const schemaDict = {
parameters: {
type: 'params',
properties: {
reasons: {
description: 'Notification reasons to include in response.',
type: 'array',
items: {
type: 'string',
description:
'A reason that matches the reason property of #notification.',
},
},
limit: {
type: 'integer',
minimum: 1,
Expand Down
2 changes: 2 additions & 0 deletions packages/ozone/src/lexicon/types/app/bsky/notification/listNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import * as AppBskyActorDefs from '../actor/defs'
import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs'

export interface QueryParams {
/** Notification reasons to include in response. */
reasons?: string[]
limit: number
priority?: boolean
cursor?: string
Expand Down
9 changes: 9 additions & 0 deletions packages/pds/src/lexicon/lexicons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8944,6 +8944,15 @@ export const schemaDict = {
parameters: {
type: 'params',
properties: {
reasons: {
description: 'Notification reasons to include in response.',
type: 'array',
items: {
type: 'string',
description:
'A reason that matches the reason property of #notification.',
},
},
limit: {
type: 'integer',
minimum: 1,
Expand Down
2 changes: 2 additions & 0 deletions packages/pds/src/lexicon/types/app/bsky/notification/listNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import * as AppBskyActorDefs from '../actor/defs'
import * as ComAtprotoLabelDefs from '../../../com/atproto/label/defs'

export interface QueryParams {
/** Notification reasons to include in response. */
reasons?: string[]
limit: number
priority?: boolean
cursor?: string
Expand Down