Add reasons param to listNotifications#3222
Merged
Merged
Conversation
Closed
dholms
reviewed
Dec 10, 2024
| "type": "array", | ||
| "items": { | ||
| "type": "string", | ||
| "description": "A reason that matches the reason property of #notification." |
Collaborator
There was a problem hiding this comment.
We originally had a knownValues here, but it was screwing up some types in the route handler and I just didn't think it was a great use of time to debug. This also prevents us from having to duplicate every new reason in 2 locations.
10 tasks
| "parameters": { | ||
| "type": "params", | ||
| "properties": { | ||
| "filter": { |
Contributor
There was a problem hiding this comment.
Wouldn't reason be less generic and better reflect what will be filtered?
ghost
approved these changes
Dec 11, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Looks good. I like @matthieusieben's suggestion.
dholms
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what I imagine I'll need.
Thementionsname is not exactly reflective of the purpose (it'll be any text — so replies, quotes, mentions all count). Could maybe call that "posts" idk. But in the UI we'll probably call it Mentions for familiarity.Rolled #3224 into this.