feat: create, dispose & reuse event stream #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
approved these changes
Aug 17, 2023
Gustl22
added a commit
that referenced
this pull request
Sep 26, 2023
# Description Currently if an event stream for a `playerId` is requested, a new stream was created, conflicting with the existing one. Now the `createEventStream`, `disposeEventStream` and `getEventStream` methods allow more control of handling the stream and also reusing the existing stream on `getEventStream`. (cherry picked from commit efbabf5)
Gustl22
added a commit
that referenced
this pull request
Nov 14, 2023
# Description Currently if an event stream for a `playerId` is requested, a new stream was created, conflicting with the existing one. Now the `createEventStream`, `disposeEventStream` and `getEventStream` methods allow more control of handling the stream and also reusing the existing stream on `getEventStream`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if an event stream for a
playerIdis requested, a new stream was created, conflicting with the existing one. Now thecreateEventStream,disposeEventStreamandgetEventStreammethods allow more control of handling the stream and also reusing the existing stream ongetEventStream.Info: this wasn't a problem so far, as one AudioPlayer only held one instance of an event stream. But this is problematic on requesting the stream multiple times on different levels in the tests.
Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
Related Issues