Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(windows): Replace virtual audio device Scream with sound-ci-helpers #1603

Merged
merged 5 commits into from
Aug 17, 2023
Merged

ci(windows): Replace virtual audio device Scream with sound-ci-helpers #1603

merged 5 commits into from
Aug 17, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Aug 14, 2023

Description

New attempt to fix time synchronization issues, introduced in #1570, see #1599.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Aug 16, 2023

See actions/runner-images#8102

@Gustl22 Gustl22 marked this pull request as ready for review August 16, 2023 23:36
@Gustl22 Gustl22 changed the title ci(windows): stop & start windows time service ci(windows): Replace virtual audio device Scream with sound-ci-helpers Aug 16, 2023
@Gustl22 Gustl22 requested review from spydon and removed request for spydon August 16, 2023 23:39
@Gustl22 Gustl22 requested a review from spydon August 17, 2023 05:40
@Gustl22 Gustl22 merged commit 440f386 into main Aug 17, 2023
@Gustl22 Gustl22 deleted the gustl22/fix-flaky-windows-time branch August 17, 2023 06:16
Gustl22 added a commit that referenced this pull request Aug 17, 2023
@Gustl22
Revert "ci(windows): Replace virtual audio device Scream with sound-c…
cfc8d09 
…i-helpers (#1603)"

This reverts commit 440f386.
@Gustl22 Gustl22 mentioned this pull request Aug 17, 2023
Merged
7 tasks
Gustl22 added a commit that referenced this pull request Aug 17, 2023
@Gustl22
Revert "ci(windows): Replace virtual audio device Scream with sound-c…
2c3e7ff 
…i-helpers (#1603)"

This reverts commit 440f386.
Gustl22 added a commit that referenced this pull request Aug 17, 2023
@Gustl22
Revert "Revert "ci(windows): Replace virtual audio device Scream with…
7e5dd50 
… sound-ci-helpers (#1603)""

This reverts commit 2c3e7ff.
Gustl22 added a commit that referenced this pull request Aug 17, 2023
@Gustl22
Revert "Revert "ci(windows): Replace virtual audio device Scream with…
1ccdd1a 
… sound-ci-helpers (#1603)""

This reverts commit cfc8d09.
Gustl22 added a commit that referenced this pull request Aug 17, 2023
@Gustl22
ci: Disable Hyper-V time sync for Windows, reenable Scream as Virtual…
a524d7f 
… Audio Device (#1608)

## Related Issues

See #1570, #1599, #1603
Gustl22 added a commit that referenced this pull request Sep 26, 2023
@Gustl22
ci(windows): Replace virtual audio device Scream with sound-ci-helpers (
5d21160 
#1603)

# Description

Replace Scream as installing the certificate is flaky, see#1570 & #1599.

(cherry picked from commit 440f386)
Gustl22 added a commit that referenced this pull request Sep 26, 2023
@Gustl22
ci: Disable Hyper-V time sync for Windows, reenable Scream as Virtual…
79d6439 
… Audio Device (#1608)

## Related Issues

See #1570, #1599, #1603

(cherry picked from commit a524d7f)
Gustl22 added a commit that referenced this pull request Nov 14, 2023
@Gustl22
ci(windows): Replace virtual audio device Scream with sound-ci-helpers (
5421683 
#1603)

# Description

Replace Scream as installing the certificate is flaky, see#1570 & #1599.
Gustl22 added a commit that referenced this pull request Nov 14, 2023
@Gustl22
ci: Disable Hyper-V time sync for Windows, reenable Scream as Virtual…
fd7fa46 
… Audio Device (#1608)

## Related Issues

See #1570, #1599, #1603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gustl22 @spydon