refactor(precompile): add new specific PrecompileError variants#2907
Merged
rakita merged 1 commit intobluealloy:mainfrom Aug 27, 2025
Merged
refactor(precompile): add new specific PrecompileError variants#2907rakita merged 1 commit intobluealloy:mainfrom
PrecompileError variants#2907rakita merged 1 commit intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #2907 will not alter performanceComparing Summary
|
3c7b3b0 to
de50364
Compare
2 tasks
rakita
requested changes
Aug 26, 2025
Member
rakita
left a comment
There was a problem hiding this comment.
Fatal and Other PrecompileErrors are needed for users of lib, so they should be brought back.
I do like that this PR adds errors of new precompiles, so we should merge that part in
rakita
reviewed
Aug 26, 2025
rakita
reviewed
Aug 26, 2025
rakita
reviewed
Aug 26, 2025
rakita
reviewed
Aug 26, 2025
rakita
reviewed
Aug 26, 2025
Contributor
Author
|
@rakita Thanks for your insightful feedback. I'll remove the errors which are not supposed to be inside revm (custom/op/examples related). And restore the error variants i deleted. Given that, making |
In cases where it is feasible, more specific variants should be used in place of the Other() error variant.
de50364 to
b8aeb94
Compare
PrecompileError compatible with CopyPrecompileError variants
Soubhik-10
added a commit
to Soubhik-10/revm
that referenced
this pull request
Sep 5, 2025
…ants (bluealloy#2907)" This reverts commit a736048.
This was referenced Sep 5, 2025
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially the goal was to make
PrecompileErrorcompatible withCopy, but this actually not possible. We can close #2906. (as not planned)So I just propose to extend
PrecompileErrorenum as in cases where it is feasible, more specific variants should be used in place of the Other() error variant.