Feature: Support bubbling up Precompile error messages #2905
Merged
rakita merged 2 commits intobluealloy:mainfrom Sep 28, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #2905 will degrade performances by 3.18%Comparing Summary
Benchmarks breakdown
|
3c7b3b0 to
832dba9
Compare
rakita
reviewed
Aug 26, 2025
rakita
requested changes
Aug 26, 2025
Member
rakita
left a comment
There was a problem hiding this comment.
We should have a different approach for this. Only place where we can return the error outside of evm is if transaction target points to the precompile.
We should introduce the mechanism that if depth == 0 and precompile returns the error for this error to be saved in Context and returned in output
d64fe87 to
52b1122
Compare
987e937 to
feba95d
Compare
feba95d to
0e07129
Compare
mablr
commented
Aug 28, 2025
rakita
reviewed
Sep 26, 2025
rakita
reviewed
Sep 26, 2025
rakita
reviewed
Sep 26, 2025
rakita
reviewed
Sep 26, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR enhances precompile error reporting and closes #2898.
Solution
Attempt to implement a mechanism that records potential precompile error in context if depth == 0, in order to bubble it up in output as Bytes. Idea proposed by Rakita #2905 (review).
TODO