Skip to content

Aggregate cleanup changes from PRs #2866, #2867, and #2874#2876

Merged
rakita merged 1 commit intomainfrom
aggregate-prs-2867-2874
Aug 10, 2025
Merged

Aggregate cleanup changes from PRs #2866, #2867, and #2874#2876
rakita merged 1 commit intomainfrom
aggregate-prs-2867-2874

Conversation

@rakita
Copy link
Copy Markdown
Member

@rakita rakita commented Aug 10, 2025

Summary

Changes included

From PR #2866

  • Fix comment reference from calc_excess_blob_gas to calc_excess_blob_gas_osaka in blob.rs

From PR #2867

  • Remove debug macro (dbg\!(&r)) from test code in inspector lib.rs

From PR #2874

  • Replace self.inner.len() == 0 with idiomatic self.inner.is_empty() in precompile lib.rs

Test plan

  • All existing tests pass
  • Changes are purely cosmetic/cleanup

🤖 Generated with Claude Code

- PR #2866: Fix comment reference from calc_excess_blob_gas to calc_excess_blob_gas_osaka
- PR #2867: Remove debug macro from test code in inspector lib
- PR #2874: Replace len() == 0 with is_empty() for idiomatic Rust

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Aug 10, 2025

CodSpeed Performance Report

Merging #2876 will degrade performances by 3.01%

Comparing aggregate-prs-2867-2874 (a791066) with main (f3c794b)

Summary

❌ 1 regressions
✅ 170 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
ecrecover precompile 198.4 µs 204.6 µs -3.01%

@rakita rakita merged commit 012aace into main Aug 10, 2025
30 of 31 checks passed
@github-actions github-actions bot mentioned this pull request Aug 8, 2025
@rakita rakita deleted the aggregate-prs-2867-2874 branch August 10, 2025 23:35
lwedge99 pushed a commit to sentioxyz/revm that referenced this pull request Sep 16, 2025
…loy#2874 (bluealloy#2876)

- PR bluealloy#2866: Fix comment reference from calc_excess_blob_gas to calc_excess_blob_gas_osaka
- PR bluealloy#2867: Remove debug macro from test code in inspector lib
- PR bluealloy#2874: Replace len() == 0 with is_empty() for idiomatic Rust

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant