refactor: use HashMap::is_empty() instead of len() == 0#2874
Closed
strmfos wants to merge 1 commit intobluealloy:mainfrom
Closed
refactor: use HashMap::is_empty() instead of len() == 0#2874strmfos wants to merge 1 commit intobluealloy:mainfrom
strmfos wants to merge 1 commit intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #2874 will not alter performanceComparing Summary
|
rakita
added a commit
that referenced
this pull request
Aug 10, 2025
- PR #2866: Fix comment reference from calc_excess_blob_gas to calc_excess_blob_gas_osaka - PR #2867: Remove debug macro from test code in inspector lib - PR #2874: Replace len() == 0 with is_empty() for idiomatic Rust 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
2 tasks
rakita
added a commit
that referenced
this pull request
Aug 10, 2025
- PR #2866: Fix comment reference from calc_excess_blob_gas to calc_excess_blob_gas_osaka - PR #2867: Remove debug macro from test code in inspector lib - PR #2874: Replace len() == 0 with is_empty() for idiomatic Rust 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
Member
|
Cleaned up here #2876 |
lwedge99
pushed a commit
to sentioxyz/revm
that referenced
this pull request
Sep 16, 2025
…loy#2874 (bluealloy#2876) - PR bluealloy#2866: Fix comment reference from calc_excess_blob_gas to calc_excess_blob_gas_osaka - PR bluealloy#2867: Remove debug macro from test code in inspector lib - PR bluealloy#2874: Replace len() == 0 with is_empty() for idiomatic Rust 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
self.inner.len() == 0withself.inner.is_empty()in Precompiles::is_empty() method. This follows Rust idioms and best practices, potentially improving readability and performance