feat: Add arkworks wrapper for bls12-381 by kevaundray · Pull Request #2316 · bluealloy/revm

kevaundray · 2025-03-26T12:57:06Z

This is based off of #2314

kevaundray · 2025-03-26T12:57:55Z

cfg flags have been added (arkworks was made as a default and blst optional) -- related to #2172

codspeed-hq · 2025-03-26T13:03:06Z

CodSpeed Performance Report

Merging #2316 will not alter performance

_{Comparing kevaundray:kw/add-arkworks-bls12-381 (db39bff) with main (89f273a)}

Summary

✅ 8 untouched benchmarks

crates/precompile/src/bls12_381/blst.rs

crates/revm/Cargo.toml

crates/precompile/src/bls12_381_utils.rs

kevaundray · 2025-03-26T14:07:27Z

CodSpeed Performance Report

Merging #2316 will not alter performance

Comparing kevaundray:kw/add-arkworks-bls12-381 (0c526ea) with main (76e1266)

Summary

✅ 8 untouched benchmarks

This should not be true -- happy to block on this while there are no benchmarks for bls12-381

Co-authored-by: rakita <rakita@users.noreply.github.com>

bins/revme/Cargo.toml

crates/precompile/Cargo.toml

crates/optimism/src/evm.rs

crates/precompile/Cargo.toml

…ch of these to import

- make arkworks non-optional but blst is the default - remove feature gate on optimism tests -- it will use arkworks if nothing is set

rakita

cool!

kevaundray added 10 commits March 26, 2025 09:49

move methods that use blst types into wrapper

0c7123a

g1.rs and g2.rs are no longer needed

d793bdc

deserialization methods have been moved into blst wrapper

c2bb3e5

refactor precompiles to use blst wrapper

ff5654a

move methods that remove padding to precompile layer

b227749

refactor precompile code

0ff0a08

function and comment refactoring

d5108c5

for type safety and invariant guarantees, use blst_scalar in the API

ac164c8

add arkworks dependency

4c91998

add initial arkworks code

22720f2

kevaundray added 2 commits March 26, 2025 13:33

make blst the default and conditionally compile arkworks-bls12-381

86c723e

move is_valid_be into blst.rs

bf7847f

kevaundray commented Mar 26, 2025

View reviewed changes

crates/precompile/src/bls12_381/blst.rs Outdated Show resolved Hide resolved

kevaundray commented Mar 26, 2025

View reviewed changes

crates/revm/Cargo.toml Outdated Show resolved Hide resolved

kevaundray commented Mar 26, 2025

View reviewed changes

crates/precompile/src/bls12_381_utils.rs Show resolved Hide resolved

kevaundray added 3 commits March 26, 2025 13:49

make blst optional and arkworks default

00e45a5

fix error message: there is a test that matches on error string

0e96bf4

add explicit imports for riscv compilation

0c526ea

kevaundray marked this pull request as ready for review March 26, 2025 14:04

replace unwrap with expect

4ac5c54

kevaundray and others added 6 commits March 27, 2025 10:42

Merge branch 'main' into kw/cleanup-blst-wrapper

8ba6e96

move is_valid_be into blst

a24aa21

Update crates/precompile/src/bls12_381/utils.rs

f3c2521

Co-authored-by: rakita <rakita@users.noreply.github.com>

Update crates/precompile/src/bls12_381/g1_msm.rs

5215fae

Co-authored-by: rakita <rakita@users.noreply.github.com>

Update crates/precompile/src/bls12_381/utils.rs

3712276

Co-authored-by: rakita <rakita@users.noreply.github.com>

Update crates/precompile/src/bls12_381/g2_msm.rs

2695bbd

Co-authored-by: rakita <rakita@users.noreply.github.com>

rakita mentioned this pull request Mar 27, 2025

Benchmarks for bls precompiles #2322

Closed

kevaundray added 6 commits March 27, 2025 13:00

use arkworks as optional

b39921b

Merge branch 'kw/cleanup-blst-wrapper' into kw/add-arkworks-bls12-381

a952183

add imports for riscv compilation

cd48c06

make blst optional, but the default

176a5d1

Merge branch 'main' into kw/add-arkworks-bls12-381

a884036

add blst back into revme and portable feature

1116cad

kevaundray commented Mar 27, 2025

View reviewed changes

bins/revme/Cargo.toml Outdated Show resolved Hide resolved

kevaundray commented Mar 27, 2025

View reviewed changes

crates/precompile/Cargo.toml Show resolved Hide resolved

kevaundray commented Mar 27, 2025

View reviewed changes

crates/optimism/src/evm.rs Show resolved Hide resolved

kevaundray commented Mar 27, 2025

View reviewed changes

crates/precompile/Cargo.toml Outdated Show resolved Hide resolved

kevaundray added 6 commits March 27, 2025 13:40

manually import std::vec::Vec because of riscv target not knowing whi…

c600f12

…ch of these to import

add feature gate on test methods that need bls

85161b4

undo cargo fmt

7cfe11b

multi:

bda5e32

- make arkworks non-optional but blst is the default - remove feature gate on optimism tests -- it will use arkworks if nothing is set

remove feature gate from isthmus fork

a4b749a

remove feature gate from prague (this didn't fail tests)

db39bff

rakita approved these changes Mar 27, 2025

View reviewed changes

rakita merged commit c26a7e8 into bluealloy:main Mar 27, 2025
29 checks passed

github-actions bot mentioned this pull request Mar 27, 2025

chore: release #2326

Closed

kevaundray mentioned this pull request Mar 28, 2025

no_std BLS12-381 Precompiles #2172

Closed

This was referenced Mar 28, 2025

chore: release #2339

Closed

chore: release #2340

Merged

kevaundray mentioned this pull request Apr 19, 2025

chore(client): Re-use msm gas calculation from REVM op-rs/kona#1236

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add arkworks wrapper for bls12-381#2316

feat: Add arkworks wrapper for bls12-381#2316
rakita merged 34 commits intobluealloy:mainfrom
kevaundray:kw/add-arkworks-bls12-381

kevaundray commented Mar 26, 2025

Uh oh!

kevaundray commented Mar 26, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevaundray commented Mar 26, 2025

CodSpeed Performance Report

Merging #2316 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rakita left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kevaundray commented Mar 26, 2025

Uh oh!

kevaundray commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #2316 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevaundray commented Mar 26, 2025

CodSpeed Performance Report

Merging #2316 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rakita left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kevaundray commented Mar 26, 2025 •

edited

Loading

codspeed-hq bot commented Mar 26, 2025 •

edited

Loading