Skip to content

chore: clean up blst wrapper doc comment and types#2314

Merged
rakita merged 14 commits intobluealloy:mainfrom
kevaundray:kw/cleanup-blst-wrapper
Mar 27, 2025
Merged

chore: clean up blst wrapper doc comment and types#2314
rakita merged 14 commits intobluealloy:mainfrom
kevaundray:kw/cleanup-blst-wrapper

Conversation

@kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Mar 26, 2025

This is based off of #2313 , mainly cleans up the abstraction and refactors comments.

Most notable changes:

  • Padding removal is done in the precompile function versus in the crypto backend
  • the crypto backend API now takes in a typed scalar, and you need to call read_scalar which guarantees that the slice that is used to construct the scalar is 32 bytes

@kevaundray kevaundray marked this pull request as ready for review March 26, 2025 11:21
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 26, 2025

CodSpeed Performance Report

Merging #2314 will not alter performance

Comparing kevaundray:kw/cleanup-blst-wrapper (2695bbd) with main (e96d047)

Summary

✅ 8 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left few nits

kevaundray and others added 4 commits March 27, 2025 12:34
Co-authored-by: rakita <rakita@users.noreply.github.com>
Co-authored-by: rakita <rakita@users.noreply.github.com>
Co-authored-by: rakita <rakita@users.noreply.github.com>
Co-authored-by: rakita <rakita@users.noreply.github.com>
@rakita rakita merged commit ab2ec2a into bluealloy:main Mar 27, 2025
29 checks passed
@github-actions github-actions bot mentioned this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants