feat: Add a wrapper for matter-labs-eip1962 for EIP196

Cargo.toml

@@ -80,6 +80,7 @@ cfg-if = { version = "1.0", default-features = false }
 clap = "4"
 criterion = { package = "codspeed-criterion-compat", version = "2.7" }
 derive-where = { version = "1.2.7", default-features = false }
+eth_pairings = { git = "https://github.com/matter-labs/eip1962", rev = "17ba98bdbdd7bdf239c09cd88ca46a486124f5e7", default-features = false }
 enumn = "0.1"
 k256 = { version = "0.13.3", default-features = false }
 kzg-rs = { version = "0.2.4", default-features = false }

crates/precompile/Cargo.toml

@@ -31,13 +31,13 @@ once_cell = { workspace = true, features = ["alloc"] }
 # ecRecover
 k256 = { workspace = true, features = ["ecdsa"] }
 secp256k1 = { workspace = true, features = [
-    "alloc",
-    "recovery",
-    "rand",
-    "global-context",
+	"alloc",
+	"recovery",
+	"rand",
+	"global-context",
 ], optional = true }
 libsecp256k1 = { workspace = true, features = [
-    "static-context",
+	"static-context",
 ], optional = true }
 
 # SHA2-256 and RIPEMD-160
@@ -49,10 +49,11 @@ aurora-engine-modexp.workspace = true
 
 # ecAdd, ecMul, ecPairing
 bn.workspace = true
+eth_pairings = { workspace = true, features = ["eip_196"], optional = true }
 
 # KZG point evaluation precompile
 c-kzg = { workspace = true, optional = true, features = [
-    "ethereum_kzg_settings",
+	"ethereum_kzg_settings",
 ] }
 
 # Optionally use `kzg-rs` for a pure Rust implementation of KZG point evaluation.
@@ -77,7 +78,14 @@ serde_json.workspace = true
 serde_derive.workspace = true
 
 [features]
-default = ["std", "c-kzg", "secp256k1", "portable", "blst"]
+default = [
+	"std",
+	"c-kzg",
+	"secp256k1",
+	"portable",
+	"blst",
+	"matter-labs-eip1962",
+]
 std = [
 	"primitives/std",
 	"k256/std",
@@ -90,7 +98,7 @@ std = [
 	"aurora-engine-modexp/std",
 	"p256?/std",
 	"serde/std",
-	"serde_json/std"
+	"serde_json/std",
 ]
 hashbrown = ["primitives/hashbrown"]
 asm-keccak = ["primitives/asm-keccak"]
@@ -118,6 +126,9 @@ libsecp256k1 = ["dep:libsecp256k1"]
 # Enables the BLS12-381 precompiles.
 blst = ["dep:blst"]
 
+# Use matter-labs implementation for BN128 operations (EIP1962)
+matter-labs-eip1962 = ["dep:eth_pairings"]
+
 [[bench]]
 name = "bench"
 path = "benches/bench.rs"

crates/precompile/src/bn128.rs

@@ -4,8 +4,22 @@ use crate::{
 };
 use std::vec::Vec;
 
-use substrate::{encode_g1_point, pairing_check, read_g1_point, read_g2_point};
-mod substrate;
+cfg_if::cfg_if! {
+    if #[cfg(feature = "matter-labs-eip1962")] {
+        mod matter_labs;
+        use matter_labs::{
+            encode_g1_point, g1_point_add, g1_point_mul, pairing_check, read_g1_point, read_g2_point,
+            read_scalar,
+        };
+    } else {
+        mod substrate;
+        use substrate::{
+            encode_g1_point, g1_point_add, g1_point_mul, pairing_check, read_g1_point, read_g2_point,
+            read_scalar,
+        };
+
+    }
+}
 
 pub mod add {
     use super::*;
@@ -121,7 +135,7 @@ pub fn run_add(input: &[u8], gas_cost: u64, gas_limit: u64) -> PrecompileResult
 
     let p1 = read_g1_point(&input[..G1_LEN])?;
     let p2 = read_g1_point(&input[G1_LEN..])?;
-    let result = p1 + p2;
+    let result = g1_point_add(p1, p2);
 
     let output = encode_g1_point(result);
 
@@ -137,10 +151,8 @@ pub fn run_mul(input: &[u8], gas_cost: u64, gas_limit: u64) -> PrecompileResult
 
     let p = read_g1_point(&input[..G1_LEN])?;
 
-    // `Fr::from_slice` can only fail when the length is not 32.
-    let fr = bn::Fr::from_slice(&input[G1_LEN..G1_LEN + SCALAR_LEN]).unwrap();
-
-    let result = p * fr;
+    let scalar = read_scalar(&input[G1_LEN..G1_LEN + SCALAR_LEN]);
+    let result = g1_point_mul(p, scalar);
 
     let output = encode_g1_point(result);