feat: Add a wrapper for matter-labs-eip1962 for EIP196#2266
Closed
kevaundray wants to merge 37 commits intobluealloy:mainfrom
Closed
feat: Add a wrapper for matter-labs-eip1962 for EIP196#2266kevaundray wants to merge 37 commits intobluealloy:mainfrom
kevaundray wants to merge 37 commits intobluealloy:mainfrom
Conversation
Contributor
Author
|
Based off of #2264 |
Contributor
Author
|
Currently to run tests against it, we do: I don't think optional dependencies are being tested against in CI, only |
kevaundray
commented
Mar 20, 2025
kevaundray
commented
Mar 20, 2025
kevaundray
commented
Mar 20, 2025
kevaundray
commented
Mar 20, 2025
kevaundray
commented
Mar 20, 2025
CodSpeed Performance ReportMerging #2266 will not alter performanceComparing Summary
|
Contributor
Author
|
On my laptop I have: Before Crypto Precompile benchmarks/precompile bench | ecrecover precompile
time: [28.906 µs 29.387 µs 29.990 µs]
change: [+1.2033% +2.1702% +3.3946%] (p = 0.00 < 0.05)
Performance has regressed.
Found 15 outliers among 100 measurements (15.00%)
3 (3.00%) low mild
6 (6.00%) high mild
6 (6.00%) high severe
Crypto Precompile benchmarks/precompile bench | bn128 add precompile
time: [2.4155 µs 2.4253 µs 2.4394 µs]
change: [-0.1218% +0.4023% +0.9439%] (p = 0.12 > 0.05)
No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe
Crypto Precompile benchmarks/precompile bench | ecpairing precompile
time: [2.5919 ms 2.5974 ms 2.6031 ms]
change: [-0.3921% -0.0444% +0.2900%] (p = 0.80 > 0.05)
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildAfter Crypto Precompile benchmarks/precompile bench | bn128 add precompile
time: [1.5845 µs 1.5889 µs 1.5940 µs]
change: [-35.061% -34.745% -34.436%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe
Benchmarking Crypto Precompile benchmarks/precompile bench | ecpairing precompile: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.4s, enable flat sampling, or reduce sample count to 50.
Crypto Precompile benchmarks/precompile bench | ecpairing precompile
time: [1.7464 ms 1.7546 ms 1.7657 ms]
change: [-32.660% -32.324% -31.960%] (p = 0.00 < 0.05)
Performance has improved.
Found 15 outliers among 100 measurements (15.00%)
4 (4.00%) low mild
7 (7.00%) high mild
4 (4.00%) high severeTo run before: Both commands were ran in the precompile directory |
Contributor
Author
|
The config flags get complicated because the optimism crate re-uses it in granite and there are tests/checks which run with --no-default-features, so tests and functions need to feature gated so that no-default-features tests/checks pass |
1abe898 to
570d449
Compare
kevaundray
commented
Mar 21, 2025
kevaundray
commented
Mar 21, 2025
kevaundray
commented
Mar 21, 2025
kevaundray
commented
Mar 21, 2025
rakita
reviewed
Mar 21, 2025
kevaundray
commented
Mar 21, 2025
kevaundray
commented
Mar 21, 2025
kevaundray
commented
Mar 21, 2025
Member
|
Superseded by #2305 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not change make any breaking changes as the default library is still sustrate-bn.
The main difference now is that the substrate-bn library is optional (this follows the same strategy that the repository uses when there are two libraries for a given functionality).
This means that substrate-bn is now explciitly specified as in a crates default features in order to enable it. Moreover, config macros were added to various parts of the code in order to pass cargo checks and tests that run with
--no-default-features.