fix: docs workflow cleanup and prevent cancellations #6713
Merged
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes long-standing docs deployment reliability issues by preventing PR preview cleanup runs from being cancelled and adding a disk-space safety net to the production docs deploy workflow.
Changes:
- Removed the unnecessary
pushtrigger from the PR docs preview workflow (keeps onlypull_requestwith docs path filtering). - Updated PR preview workflow concurrency config to explicitly set
cancel-in-progress: falseso cleanup runs aren’t cancelled. - Added a pre-flight “Free disk space” step to the production docs deploy workflow to reduce runner disk exhaustion failures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/pr-website-preview.yml | Removes redundant trigger and makes concurrency behavior explicit to prevent cleanup cancellation. |
| .github/workflows/deploy-docs-and-extensions.yml | Adds runner disk cleanup step ahead of the docs build/deploy to reduce failures from low disk space. |
- Remove unnecessary push trigger from pr-website-preview.yml The push trigger was running on every push to every branch but doing nothing useful (deploy step was skipped due to missing PR context). The pull_request trigger with 'synchronize' already handles PR updates. - Add cancel-in-progress: false to pr-website-preview.yml This prevents cleanup jobs from being cancelled when they run concurrently with deploy jobs, which was causing PR previews to accumulate and fill up disk space.
blackgirlbytes
force-pushed
the
fix/docs-workflow-cleanup
branch
from
225cf26 to
57d5548
Compare
dianed-square
approved these changes
Jan 26, 2026
This was referenced Jan 27, 2026
zanesq
added a commit
that referenced
this pull request
Jan 27, 2026
…upport * origin/main: (79 commits) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700) fix: Manual compaction does not update context window. (#6682) Removed the Acceptable Usage Policy (#6204) Document spellcheck toggle (#6721) fix: docs workflow cleanup and prevent cancellations (#6713) Docs: file bug directly (#6718) fix: dispatch ADD_ACTIVE_SESSION event before navigating from "View All" (#6679) Speed up Databricks provider init by removing fetch of supported models (#6616) fix: correct typos in documentation and Justfile (#6686) docs: frameDomains and baseUriDomains for mcp apps (#6684) docs: add Remotion video creation tutorial (#6675) docs: export recipe and copy yaml (#6680) ... # Conflicts: # ui/desktop/src/hooks/useChatStream.ts
katzdave
added a commit
that referenced
this pull request
Jan 27, 2026
…ovider * 'main' of github.com:block/goose: fix: Manual compaction does not update context window. (#6682) Removed the Acceptable Usage Policy (#6204) Document spellcheck toggle (#6721) fix: docs workflow cleanup and prevent cancellations (#6713) Docs: file bug directly (#6718) fix: dispatch ADD_ACTIVE_SESSION event before navigating from "View All" (#6679) Speed up Databricks provider init by removing fetch of supported models (#6616) fix: correct typos in documentation and Justfile (#6686) docs: frameDomains and baseUriDomains for mcp apps (#6684)
zanesq
added a commit
that referenced
this pull request
Jan 27, 2026
* 'main' of github.com:block/goose: Create default gooseignore file when missing (#6498) fix slash and @ keyboard navigation popover background color (#6550) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700) fix: Manual compaction does not update context window. (#6682) Removed the Acceptable Usage Policy (#6204) Document spellcheck toggle (#6721) fix: docs workflow cleanup and prevent cancellations (#6713) Docs: file bug directly (#6718)
This was referenced Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the docs deployment workflow issues that have been causing failures for months.
Root Causes Found
PR preview cleanup jobs were being cancelled - The
pr-website-preview.ymlworkflow was missingcancel-in-progress: false, so when a PR was merged, the cleanup job would get cancelled by the deploy job (both in the same concurrency group). This caused PR previews to accumulate.Unnecessary
pushtrigger was wasting CI and causing conflicts - The preview workflow had apushtrigger that ran on every push to every branch (except dependabot). This was:Disk space filled up - The accumulated PR previews (6.5GB) filled up the GitHub Actions runner disk space, causing deploy failures.
Changes
pr-website-preview.yml:pushtrigger (thepull_requesttrigger withsynchronizealready handles PR updates)cancel-in-progress: falseto match the deploy workflow and prevent cleanup jobs from being cancelleddeploy-docs-and-extensions.yml:Already Done
Testing
After this PR merges, the next docs PR that gets merged should: