chore: [CONTRIBUTING.md] add Hermit to instructions #6518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yorisoft
changed the title
taniandjerry
changed the title
blackgirlbytes
requested changes
Jan 16, 2026
Contributor
blackgirlbytes
left a comment
blackgirlbytes
left a comment
There was a problem hiding this comment.
thanks but im not too sure we need this PR. I think it changes a lot of things we were trying to be intentional about. I can help you find some issues where we truly need assistance!
CONTRIBUTING.md
Outdated
| ## Quick Responsible AI Tips | ||
|
|
||
| If you use Goose, Copilot, Claude, or other AI tools to help with your PRs: | ||
| If using Goose, or other AI tools to help with contributions: |
Contributor
There was a problem hiding this comment.
hmm we're okay with other AI tools using AI tools besides goose...
Contributor
|
There are some beneficial additions you added about hermit activation, the short hand -s for signoff, and you fixed a typo where it said "settups" and "submiting" . Thank you. Let's keep those. But if possible can you remove the other changes..our voice and branding for new contributors to goose is intentionally warm and friendly 😄 |
Yorisoft
force-pushed
the
yorisoft/edit_readme_for_cargo_builds
branch
from
c1de8d4 to
4ba0ca3
Compare
Contributor
Author
|
@blackgirlbytes Should be ready now |
CONTRIBUTING.md
Outdated
| ### Before Submitting a Pull Request | ||
|
|
||
| Before you submit a pull request, please ensure your fork is synchronized as described above. This check ensures your changes are compatible with the latest in the main repository and streamlines the review process. | ||
| Before submitting a pull request, please ensure your fork is synchronized as described above. This check ensures your changes are compatible with the latest in the main repository and streamlines the review process. |
Contributor
There was a problem hiding this comment.
I would keep the language as was written. "you submit" is meant to feel more personal!
CONTRIBUTING.md
Outdated
|
|
||
| First let's compile goose and try it out | ||
| First let's activate Hermit. | ||
| Goose requires Hermit for managing dependencies. |
Contributor
There was a problem hiding this comment.
how about a minor change that combines what was there to bring it together?
- First let's compile goose and try it out
- Since goose requires Hermit for managing dependencies, let's activate hermit.
taniandjerry
requested changes
Jan 16, 2026
Contributor
taniandjerry
left a comment
taniandjerry
left a comment
There was a problem hiding this comment.
Left minor feedback to keep language carefully written from before, while also accepting the Hermit contribution to this guide
taniandjerry
changed the title
Yorisoft
force-pushed
the
yorisoft/edit_readme_for_cargo_builds
branch
from
4ba0ca3 to
5783416
Compare
Contributor
Author
|
@taniandjerry |
blackgirlbytes
approved these changes
Jan 20, 2026
Contributor
|
oh please fix the merge conflict and i can merge it! |
Collaborator
|
@Yorisoft checking if you can fix the merge conflicts and we will merge asap thanks! |
Yorisoft
force-pushed
the
yorisoft/edit_readme_for_cargo_builds
branch
from
9c3e466 to
f303b2b
Compare
Signed-off-by: Yelsin Sepulveda <[email protected]>
Signed-off-by: Yelsin Sepulveda <[email protected]>
Yorisoft
force-pushed
the
yorisoft/edit_readme_for_cargo_builds
branch
from
f303b2b to
bfa3985
Compare
zanesq
added a commit
that referenced
this pull request
Jan 27, 2026
…upport * origin/main: (79 commits) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700) fix: Manual compaction does not update context window. (#6682) Removed the Acceptable Usage Policy (#6204) Document spellcheck toggle (#6721) fix: docs workflow cleanup and prevent cancellations (#6713) Docs: file bug directly (#6718) fix: dispatch ADD_ACTIVE_SESSION event before navigating from "View All" (#6679) Speed up Databricks provider init by removing fetch of supported models (#6616) fix: correct typos in documentation and Justfile (#6686) docs: frameDomains and baseUriDomains for mcp apps (#6684) docs: add Remotion video creation tutorial (#6675) docs: export recipe and copy yaml (#6680) ... # Conflicts: # ui/desktop/src/hooks/useChatStream.ts
katzdave
added a commit
that referenced
this pull request
Jan 27, 2026
…ovider * 'main' of github.com:block/goose: fix slash and @ keyboard navigation popover background color (#6550) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700)
zanesq
added a commit
that referenced
this pull request
Jan 27, 2026
* 'main' of github.com:block/goose: Create default gooseignore file when missing (#6498) fix slash and @ keyboard navigation popover background color (#6550) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700) fix: Manual compaction does not update context window. (#6682) Removed the Acceptable Usage Policy (#6204) Document spellcheck toggle (#6721) fix: docs workflow cleanup and prevent cancellations (#6713) Docs: file bug directly (#6718)
This was referenced Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
AI Assistance
Testing
Related Issues
Relates to: fixes #6517
Screenshots/Demos (for UX changes)
Before:
https://github.com/block/goose/blob/main/CONTRIBUTING.md
After:
https://gist.github.com/Yorisoft/33b425458da52d6e2b1a341d9e9c5091