fix: use .config/agents (plural) for skills directory #6357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for .config/agents and .agents directories (plural form) to the skills discovery path, making skills portable across different AI coding agents. The documentation files are new additions that describe this functionality.
- Adds
.config/agents/skillsand.agents/skillsto the skills discovery directories - Updates extension description to be more generic
- Adds comprehensive documentation for the Skills extension and skill usage
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
documentation/docs/mcp/skills-mcp.md |
New documentation file describing the Skills extension, its configuration, and example usage |
documentation/docs/guides/context-engineering/using-skills.md |
New comprehensive guide on creating and using skills, including file structure and best practices |
crates/goose/src/agents/skills_extension.rs |
Adds .config/agents/skills (line 86) and .agents/skills (line 94) to skill discovery directories |
crates/goose/src/agents/extension.rs |
Updates description from specific directories to generic "relevant directories" |
The changes look good! The code properly adds the new directories in the correct precedence order, matching the documentation. The implementation maintains backward compatibility by keeping all existing paths while adding the new portable ones.
Removed comments indicating priority of skill directories. Signed-off-by: Joah Gerstenberg <joah@squareup.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019b37b4-e1cd-7194-ae9f-4c277e47ffb5 Co-authored-by: Amp <amp@ampcode.com>
joahg
force-pushed
the
fix/skills-config-path
branch
from
d496750 to
f1263ab
Compare
The documentation specifies ~/.config/agents/skills/ as the global skills directory, but the code was using ~/.config/agent/skills/ (singular). This fixes the mismatch to match the documented path. Amp-Thread-ID: https://ampcode.com/threads/T-019b9485-527c-7190-a8f6-0c2f4c532dc7 Co-authored-by: Amp <amp@ampcode.com>
joahg
force-pushed
the
fix/skills-config-path
branch
from
f1263ab to
2231c2e
Compare
dianed-square
approved these changes
Jan 6, 2026
alexhancock
approved these changes
Jan 6, 2026
zanesq
added a commit
that referenced
this pull request
Jan 7, 2026
* 'main' of github.com:block/goose: Claude 3.7 is out. we had some harcoded stuff (#6197) Release 1.19.0 chore: upgrade to node v24 as engine (#6361) chore(deps): bump rsa from 0.9.9 to 0.9.10 (#6358) Bump rust toolchain to 1.92 (current stable) (#6356) Hide advanced recipe options under expandable content (#6021) fix: use .config/agents (plural) for skills directory (#6357) fix: prevent KaTeX from treating underscores as subscripts in plain text (#6242) fix: make goose review PRs more like goose contributors do (#6240) fix : preserve provider engine type when editing custom providers (#6106) feat(providers): add retry for model fetching (#6347) allow goose issue solver to react to activation comments (#6239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The documentation specifies
~/.config/agents/skills/as the global skills directory, but the code was using~/.config/agent/skills/(singular). This fixes the mismatch to match the documented path.Changes
skills_extension.rsto use.config/agents/skillsinstead of.config/agent/skillsReferences
Documentation references:
documentation/docs/mcp/skills-mcp.mddocumentation/docs/guides/context-engineering/using-skills.md