Bump rust toolchain to 1.92 (current stable) #6356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust toolchain from version 1.88.0 to 1.92 (current stable) and upgrades the rustup package manager from version 1.25.2 to 1.28.2.
Key Changes:
- Updated Rust toolchain channel from 1.88.0 to 1.92 in the toolchain configuration
- Upgraded rustup from version 1.25.2 to 1.28.2 across all Rust binary tools
- Removed the old rustup 1.25.2 package file
Reviewed changes
Copilot reviewed 1 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Updated Rust toolchain channel from 1.88.0 to 1.92 |
| bin/rustup | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/rustfmt | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/rustdoc | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/rustc | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/rust-lldb | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/rust-gdbgui | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/rust-gdb | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/rust-analyzer | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/rls | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/clippy-driver | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/cargo-miri | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/cargo-fmt | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/cargo-clippy | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/cargo | Updated rustup package reference from 1.25.2 to 1.28.2 |
| bin/.rustup-1.25.2.pkg | Removed old rustup package file |
| Self: Sized, | ||
| { | ||
| let model_strings: Vec<String> = vec![ | ||
| let model_strings: Vec<String> = [ |
There was a problem hiding this comment.
Type mismatch: assigning an array directly to a Vec variable. The array should be followed by .to_vec() or the type annotation should be removed to allow type inference.
| #[test] | ||
| fn test_valid_conversation() { | ||
| let all_messages = vec
alexhancock
approved these changes
Jan 6, 2026
alexhancock
reviewed
Jan 6, 2026
| )) | ||
| } | ||
|
|
||
| #[derive(Serialize, Deserialize, Debug)] |
Collaborator
There was a problem hiding this comment.
were these just unused?
Collaborator
Author
There was a problem hiding this comment.
Yeah seems so, and I'm not sure why it wasn't flagged by the build before, but I'm guessing some improvements were made between 1.88 and 1.92 to finding dead code
jamadeo
added a commit
that referenced
this pull request
Jan 6, 2026
zanesq
added a commit
that referenced
this pull request
Jan 7, 2026
* 'main' of github.com:block/goose: Claude 3.7 is out. we had some harcoded stuff (#6197) Release 1.19.0 chore: upgrade to node v24 as engine (#6361) chore(deps): bump rsa from 0.9.9 to 0.9.10 (#6358) Bump rust toolchain to 1.92 (current stable) (#6356) Hide advanced recipe options under expandable content (#6021) fix: use .config/agents (plural) for skills directory (#6357) fix: prevent KaTeX from treating underscores as subscripts in plain text (#6242) fix: make goose review PRs more like goose contributors do (#6240) fix : preserve provider engine type when editing custom providers (#6106) feat(providers): add retry for model fetching (#6347) allow goose issue solver to react to activation comments (#6239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.