Skip to content

Conversation

@jamadeo
Copy link
Collaborator

@jamadeo jamadeo commented Jan 5, 2026

As documented here, dependabot PRs are like fork PRs in that they don't have access to secrets. This means the smoke tests can't run on them.

Copilot AI review requested due to automatic review settings January 5, 2026 18:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents smoke tests from running on dependabot PRs, which lack access to repository secrets (similar to fork PRs).

Key Changes

  • Added a condition to skip smoke tests when the workflow actor is dependabot[bot]

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok. I do wonder if we can just pull the pin and run smoke tests on PRs as well (although using GH secrets I guess not possible?)

@jamadeo
Copy link
Collaborator Author

jamadeo commented Jan 5, 2026

Running on PRs with secrets access makes the API tokens easily steal-able. If we can find a way around that we could make it happen

@jamadeo jamadeo merged commit 02743e8 into main Jan 5, 2026
26 checks passed
@jamadeo jamadeo deleted the skip-smoke-tests-for-dependabot branch January 5, 2026 20:07
zanesq added a commit that referenced this pull request Jan 6, 2026
* 'main' of github.com:block/goose:
  refactor:  when changing provider/model,load existing provider/model (#6334)
  chore: refactor configure_extensions_dialog to reduce line count (#6277)
  chore: refactor handle_configure to reduce line count (#6276)
  chore: refactor interactive session to reduce line count (#6274)
  chore: refactor docx_tool to reduce function size (#6273)
  chore: refactor cli() function to reduce line count (#6272)
  make sure the models are using streaming properly (#6331)
  feat: add a max tokens env var (#6264)
  docs: slash commands topic (#6333)
  fix(ci): prevent gh-pages branch bloat (#6340)
  chore(deps): bump qs and body-parser in /documentation (#6338)
  Skip the smoke tests for dependabot PRs (#6337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants