chore: refactor configure_extensions_dialog to reduce line count #6277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR successfully refactors the configure_extensions_dialog function from 353 lines to 36 lines by extracting common prompting and configuration logic into focused helper functions. The refactoring improves code maintainability and readability while preserving all existing functionality.
Key changes:
- Extracted 9 helper functions for reusable prompting and configuration logic
- Standardized description validation across all extension types (fixing a validation bug in the process)
- Maintained identical behavior for all extension configuration flows
baxen
changed the title
DOsinga
approved these changes
Jan 5, 2026
alexhancock
approved these changes
Jan 5, 2026
zanesq
added a commit
that referenced
this pull request
Jan 6, 2026
* 'main' of github.com:block/goose: refactor: when changing provider/model,load existing provider/model (#6334) chore: refactor configure_extensions_dialog to reduce line count (#6277) chore: refactor handle_configure to reduce line count (#6276) chore: refactor interactive session to reduce line count (#6274) chore: refactor docx_tool to reduce function size (#6273) chore: refactor cli() function to reduce line count (#6272) make sure the models are using streaming properly (#6331) feat: add a max tokens env var (#6264) docs: slash commands topic (#6333) fix(ci): prevent gh-pages branch bloat (#6340) chore(deps): bump qs and body-parser in /documentation (#6338) Skip the smoke tests for dependabot PRs (#6337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the
configure_extensions_dialogfunction from 353 lines down to 36 lines by extracting common functionality into focused helper functions.Changes
Split the monolithic function into smaller, reusable helpers:
prompt_extension_timeout(): Prompts for extension timeoutprompt_extension_description(): Prompts for extension descriptionprompt_extension_name(): Prompts for extension name with validationcollect_env_vars(): Collects environment variables interactivelycollect_headers(): Collects custom headers interactivelyconfigure_builtin_extension(): Handles built-in extension setupconfigure_stdio_extension(): Handles stdio extension setupconfigure_sse_extension(): Handles SSE extension setupconfigure_streamable_http_extension(): Handles streaming HTTP setupResult
The refactoring improves code readability and maintainability while preserving all existing functionality.
Testing
cargo build -p goose-cli✅cargo fmt✅cargo clippy -p goose-cli -- -D warnings✅./scripts/clippy-lint.sh✅