fix: use correct parameter name in read_module handler #6148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handler was looking for 'path' but the ReadModuleParams schema defines 'module_path'. This caused the tool to fail with 'Missing required parameter: path' when the LLM correctly used 'module_path'. Signed-off-by: rabi <[email protected]>
DOsinga
approved these changes
Dec 17, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
Nice. thanks. we could consider turning it into a string constant so we are always sure we use the same thing in the three places where it is used
Contributor
Author
We could, but I've left it as inline string literal for consistency with existing codebase patterns. Please see similar usage in |
Collaborator
|
fair enough. we should though |
zanesq
added a commit
that referenced
this pull request
Dec 18, 2025
* 'main' of github.com:block/goose: (28 commits) Clean PR preview sites from gh-pages branch history (#6161) fix: make goose reviewer less sycophantic (#6171) revert /reply to previous behavior (replacing session history) when full conversation provided (#6058) chore: manually update version (#6166) Integrate pricing with canonical model (#6130) Regenerate canonical models when release branch is created. (#6127) fix: use correct parameter name in read_module handler (#6148) docs: blog for code mode MCP (#6126) test: add ACP integration test (#6150) docs: auto download updates (#6163) fix: respect default_enabled value of platform extensions (#6159) docs: skills (#6062) fix: add conditional configuration for GOOSE_BIN_DIR in PATH (#5940) Update dependencies to help in Fedora packaging (#5835) fix: make goose reviewer less bad (#6154) docs: create/edit recipe button (#6145) fix(google): Fix 400 Bad Request error with Gemini 3 thought signatures (#6035) fix: we don't need to warn about tool count when in code mode (#6149) deps: upgrade agent-client-protocol to 0.9.0 (#6109) fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 (#5966) ... # Conflicts: # ui/desktop/src/api/sdk.gen.ts # ui/desktop/src/hooks/useAgent.ts
bkvarda
pushed a commit
to bkvarda/goose
that referenced
this pull request
Dec 19, 2025
Signed-off-by: rabi <[email protected]> Signed-off-by: Brandon Kvarda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handler is looking for 'path' but the ReadModuleParams schema defines 'module_path'. This caused the tool to fail with 'Missing required parameter: path' when the LLM correctly used 'module_path'.
Type of Change
Testing
Unit and manual testing with main branch build
Related Issues
Relates to: #6147