5527 multiple file popups #5905

benjamindrussell · 2025-11-27T18:47:23Z

Summary

Added state to track file picker status, disabled the button when file picker open.
Also, not mentioned in the original issue but the same behavior occurs for the directory chooser as well so I went ahead and fixed it.
Added state to track directory chooser status, disabled the button when directory chooser open.

Type of Change

AI Assistance

This PR was created or reviewed with AI assistance

Testing

Manual Testing

Related Issues

Relates to #5527
Discussion: LINK (if any)

Screenshots/Demos (for UX changes)

Before:

After:

Submitting a Recipe?

Email:

Copilot

Pull request overview

This PR fixes a bug where users could open multiple file picker or directory chooser dialogs by rapidly clicking the corresponding buttons. The fix adds state tracking to prevent re-opening dialogs while one is already active.

Key changes:

Added state management to track when pickers/choosers are open
Disabled buttons and added visual feedback (opacity) during picker/chooser operations
Wrapped async operations in try-finally blocks to ensure cleanup

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
ui/desktop/src/components/bottom_menu/DirSwitcher.tsx	Adds `isDirectoryChooserOpen` state, disables button during directory selection, and prevents tooltip from showing when chooser is active
ui/desktop/src/components/ChatInput.tsx	Adds `isFilePickerOpen` state and disables file attachment button during file selection

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

…active Signed-off-by: benjamindrussell <[email protected]>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

The-Best-Codes · 2025-11-28T01:21:08Z

FYI, there is a PR (#5640) for the issue already. The author of that PR was the first to begin work on issue #5527, and they are assigned to it.

The-Best-Codes · 2025-11-28T01:29:29Z

ui/desktop/src/components/bottom_menu/DirSwitcher.tsx

+    if (isDirectoryChooserOpen) {
+      event.preventDefault();
+      event.stopPropagation();
+      return;
+    }


Just out of curiosity, can you explain why just using return; won't work here?

Yeah, returning only exits the handler, it doesn’t cancel the browser’s default behavior or stop the event from bubbling. We could remove preventDefault and add a type="button" to the button, since the default type is submit. TBH it would probably still work fine with just return.

benjamindrussell · 2025-11-28T01:51:59Z

FYI, there is a PR (#5640) for the issue already. The author of that PR was the first to begin work on issue #5527, and they are assigned to it.

Ah I see, I'm happy to change the scope of this PR to just fix the behavior of the directory chooser if necessary.

* origin/main: Update Anthropic and Google Gemini models to latest API versions (#5980) docs: chat recall tutorial (#5975) fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967) 5527 multiple file popups (#5905) Groq configure fix (#5833) added sidebar contextual information for firefox (#5433) docs: council of mine MCP (#5979) docs: nano banana extension (#5977) fix: remove prompt change, read model from config (#5976) Enable recipe deeplink parameters for pre-population (#5757) chore: upgrade npm packages (#5951) feat: ActionRequired (#5897) feat(acp): support loading sessions in acp (#5942) docs: add videos to multi-model page (#5938) docs: promote planning guide (#5934)

* main: fix params not being substituted in activities (#5992) blog: MCP Sampling (#5987) Update Anthropic and Google Gemini models to latest API versions (#5980) docs: chat recall tutorial (#5975) fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967) 5527 multiple file popups (#5905) Groq configure fix (#5833) added sidebar contextual information for firefox (#5433) docs: council of mine MCP (#5979) docs: nano banana extension (#5977) fix: remove prompt change, read model from config (#5976) Enable recipe deeplink parameters for pre-population (#5757)

…nses-streaming * 'main' of github.com:block/goose: blog: MCP Sampling (#5987) Update Anthropic and Google Gemini models to latest API versions (#5980) docs: chat recall tutorial (#5975) fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967) 5527 multiple file popups (#5905) Groq configure fix (#5833) added sidebar contextual information for firefox (#5433) docs: council of mine MCP (#5979) docs: nano banana extension (#5977) fix: remove prompt change, read model from config (#5976) Enable recipe deeplink parameters for pre-population (#5757) chore: upgrade npm packages (#5951) feat: ActionRequired (#5897) feat(acp): support loading sessions in acp (#5942) docs: add videos to multi-model page (#5938)

* 'main' of github.com:block/goose: (21 commits) Hide recipe icon in empty chat (#6022) docs: provider and model config (#6008) Show modal selector after configuring a provider (#6005) docs: additional mcp sampling resources (#6020) Flutter PR Code Review (#6011) feat(mcp): elicitation support (#5965) Onboarding detect provider from api key (#5955) Fix PATH on Windows for extensions (#6000) recipe(datahub): Add a recipe for searching & understanding data in DataHub (#5859) fix params not being substituted in activities (#5992) blog: MCP Sampling (#5987) Update Anthropic and Google Gemini models to latest API versions (#5980) docs: chat recall tutorial (#5975) fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967) 5527 multiple file popups (#5905) Groq configure fix (#5833) added sidebar contextual information for firefox (#5433) docs: council of mine MCP (#5979) docs: nano banana extension (#5977) fix: remove prompt change, read model from config (#5976) ... # Conflicts: # ui/desktop/src/api/sdk.gen.ts # ui/desktop/src/components/bottom_menu/DirSwitcher.tsx

* 'main' of github.com:block/goose: (159 commits) Cleanup: Remove Recipe Key Flow (#6015) chore(deps): bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /documentation (#5963) remove problematic corrupted woff font (#6006) Added search bar / filtering for recipes (#6019) Hide recipe icon in empty chat (#6022) docs: provider and model config (#6008) Show modal selector after configuring a provider (#6005) docs: additional mcp sampling resources (#6020) Flutter PR Code Review (#6011) feat(mcp): elicitation support (#5965) Onboarding detect provider from api key (#5955) Fix PATH on Windows for extensions (#6000) recipe(datahub): Add a recipe for searching & understanding data in DataHub (#5859) fix params not being substituted in activities (#5992) blog: MCP Sampling (#5987) Update Anthropic and Google Gemini models to latest API versions (#5980) docs: chat recall tutorial (#5975) fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967) 5527 multiple file popups (#5905) Groq configure fix (#5833) ...

Copilot AI review requested due to automatic review settings November 27, 2025 18:47

Copilot started reviewing on behalf of benjamindrussell November 27, 2025 18:48 View session

Copilot finished reviewing on behalf of benjamindrussell November 27, 2025 18:48

Copilot AI reviewed Nov 27, 2025

View reviewed changes

disabled file picker button and directory chooser button when popups …

f30a0f6

…active Signed-off-by: benjamindrussell <[email protected]>

benjamindrussell force-pushed the 5527-multiple-file-popups branch from 3bcc306 to 70a4c2e Compare November 27, 2025 18:52

benjamindrussell requested a review from a team as a code owner November 27, 2025 18:52

angiejones force-pushed the 5527-multiple-file-popups branch from 70a4c2e to f30a0f6 Compare November 28, 2025 00:41

angiejones requested review from Copilot and removed request for a team November 28, 2025 00:41

Copilot started reviewing on behalf of angiejones November 28, 2025 00:42 View session

Copilot finished reviewing on behalf of angiejones November 28, 2025 00:43

Copilot AI reviewed Nov 28, 2025

View reviewed changes

The-Best-Codes reviewed Nov 28, 2025

View reviewed changes

DOsinga approved these changes Dec 4, 2025

View reviewed changes

DOsinga merged commit 2134438 into block:main Dec 4, 2025
22 checks passed

github-actions bot mentioned this pull request Dec 4, 2025

chore(release): release version 1.16.0 (minor) #5985

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

5527 multiple file popups #5905

5527 multiple file popups #5905

benjamindrussell commented Nov 27, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

The-Best-Codes commented Nov 28, 2025 •

edited

Loading

Uh oh!

The-Best-Codes Nov 28, 2025

Uh oh!

benjamindrussell Nov 28, 2025

Uh oh!

benjamindrussell commented Nov 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

5527 multiple file popups #5905

5527 multiple file popups #5905

Conversation

benjamindrussell commented Nov 27, 2025

Summary

Type of Change

AI Assistance

Testing

Related Issues

Screenshots/Demos (for UX changes)

Submitting a Recipe?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

The-Best-Codes commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

The-Best-Codes Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

benjamindrussell Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

benjamindrussell commented Nov 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

The-Best-Codes commented Nov 28, 2025 •

edited

Loading