Skip to content

Conversation

@40u5
Copy link
Contributor

@40u5 40u5 commented Oct 29, 2025

Summary

since firefox's browser sends a parameter with the name of q as the prompt when the summarize with AI button is clicked, I allowed the server to take the q parameter, and when it does it simply adds that prompt to the textarea

Type of Change

  • [ ✅] Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

Testing

Manual testing

Related Issues

Relates to #5373
Discussion: LINK (if any)

Screenshots/Demos (for UX changes)

Before:

After:

Email:

@40u5 40u5 force-pushed the Firefox-sidebar-contextual-integration branch from 6c2a371 to 67d01b0 Compare October 29, 2025 03:29
@taniandjerry
Copy link
Contributor

Thank you for the contribution. Requested review from the dev team to help!

Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions

// Load all messages from session
sessionData.messages.forEach(msg => {
addMessage(msg.content, msg.role, msg.timestamp);
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, accidentally added that to the commit

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, so please remove?

}

// Populate query parameter if present
getQueryParam();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this means if you reload the page, we put the query into the box again? is that what you want?

Copy link
Contributor Author

@40u5 40u5 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my new pr, it removes the q parameter from the URL so that it wouldn't keep adding the text into the box on reload. open webui does something similar where it submits the message when the q= parameter is included.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is your new PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant new changes to the current pr

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using the URL class seems cleaner, something like:

function getQueryParam() {
const url = new URL(window.location.href);
const query = url.searchParams.get('q');

if (query) {
    messageInput.value = query;
    url.searchParams.delete('q');
    window.history.replaceState({}, '', url.toString());
}

}

@DOsinga DOsinga added the waiting label Nov 8, 2025
Signed-off-by: 40u5 <[email protected]>

removed q parameter after search
@40u5 40u5 force-pushed the Firefox-sidebar-contextual-integration branch from 0d1cc81 to efd8909 Compare November 17, 2025 05:12
@DOsinga
Copy link
Collaborator

DOsinga commented Nov 20, 2025

all good. can you remove that thing that got dragged in from the other pr?

@40u5 40u5 force-pushed the Firefox-sidebar-contextual-integration branch from f577338 to f148ede Compare November 21, 2025 04:43
@michaelneale
Copy link
Collaborator

looks ok now @DOsinga ?

@DOsinga DOsinga merged commit 3a378b2 into block:main Dec 4, 2025
16 checks passed
tlongwell-block added a commit that referenced this pull request Dec 4, 2025
* origin/main:
  Update Anthropic and Google Gemini models to latest API versions (#5980)
  docs: chat recall tutorial (#5975)
  fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967)
  5527 multiple file popups (#5905)
  Groq configure fix  (#5833)
  added sidebar contextual information for firefox (#5433)
  docs: council of mine MCP (#5979)
  docs: nano banana extension (#5977)
  fix: remove prompt change, read model from config (#5976)
  Enable recipe deeplink parameters for pre-population (#5757)
  chore: upgrade npm packages (#5951)
  feat: ActionRequired (#5897)
  feat(acp): support loading sessions in acp (#5942)
  docs: add videos to multi-model page (#5938)
  docs: promote planning guide (#5934)
michaelneale added a commit that referenced this pull request Dec 5, 2025
* main:
  fix params not being substituted in activities (#5992)
  blog: MCP Sampling (#5987)
  Update Anthropic and Google Gemini models to latest API versions (#5980)
  docs: chat recall tutorial (#5975)
  fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967)
  5527 multiple file popups (#5905)
  Groq configure fix  (#5833)
  added sidebar contextual information for firefox (#5433)
  docs: council of mine MCP (#5979)
  docs: nano banana extension (#5977)
  fix: remove prompt change, read model from config (#5976)
  Enable recipe deeplink parameters for pre-population (#5757)
katzdave added a commit that referenced this pull request Dec 5, 2025
…nses-streaming

* 'main' of github.com:block/goose:
  blog: MCP Sampling (#5987)
  Update Anthropic and Google Gemini models to latest API versions (#5980)
  docs: chat recall tutorial (#5975)
  fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967)
  5527 multiple file popups (#5905)
  Groq configure fix  (#5833)
  added sidebar contextual information for firefox (#5433)
  docs: council of mine MCP (#5979)
  docs: nano banana extension (#5977)
  fix: remove prompt change, read model from config (#5976)
  Enable recipe deeplink parameters for pre-population (#5757)
  chore: upgrade npm packages (#5951)
  feat: ActionRequired (#5897)
  feat(acp): support loading sessions in acp (#5942)
  docs: add videos to multi-model page (#5938)
zanesq added a commit that referenced this pull request Dec 8, 2025
* 'main' of github.com:block/goose: (21 commits)
  Hide recipe icon in empty chat (#6022)
  docs: provider and model config (#6008)
  Show modal selector after configuring a provider (#6005)
  docs: additional mcp sampling resources (#6020)
  Flutter PR Code Review (#6011)
  feat(mcp): elicitation support (#5965)
  Onboarding detect provider from api key (#5955)
  Fix PATH on Windows for extensions (#6000)
  recipe(datahub): Add a recipe for searching & understanding data in DataHub (#5859)
  fix params not being substituted in activities (#5992)
  blog: MCP Sampling (#5987)
  Update Anthropic and Google Gemini models to latest API versions (#5980)
  docs: chat recall tutorial (#5975)
  fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967)
  5527 multiple file popups (#5905)
  Groq configure fix  (#5833)
  added sidebar contextual information for firefox (#5433)
  docs: council of mine MCP (#5979)
  docs: nano banana extension (#5977)
  fix: remove prompt change, read model from config (#5976)
  ...

# Conflicts:
#	ui/desktop/src/api/sdk.gen.ts
#	ui/desktop/src/components/bottom_menu/DirSwitcher.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants